render / rpms / libvirt

Forked from rpms/libvirt 11 months ago
Clone
Daniel P. Berrange d7239a
commit efc2594b4e0cbcdd6947fafeeed41accd5b611e0
Daniel P. Berrange d7239a
Author: Jim Fehlig <jfehlig@novell.com>
Daniel P. Berrange d7239a
Date:   Thu Feb 17 14:22:55 2011 -0700
Daniel P. Berrange d7239a
Daniel P. Berrange d7239a
    Do not add drive 'boot=on' param when a kernel is specified
Daniel P. Berrange d7239a
    
Daniel P. Berrange d7239a
    libvirt-tck was failing several domain tests [1] with qemu 0.14, which
Daniel P. Berrange d7239a
    is now less tolerable of specifying 2 bootroms with the same boot index [2].
Daniel P. Berrange d7239a
    
Daniel P. Berrange d7239a
    Drop the 'boot=on' param if kernel has been specfied.
Daniel P. Berrange d7239a
    
Daniel P. Berrange d7239a
    [1] https://www.redhat.com/archives/libvir-list/2011-February/msg00559.html
Daniel P. Berrange d7239a
    [2] http://lists.nongnu.org/archive/html/qemu-devel/2011-02/msg01892.html
Daniel P. Berrange d7239a
Daniel P. Berrange d7239a
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
Daniel P. Berrange d7239a
index 371a7ed..0db2843 100644
Daniel P. Berrange d7239a
--- a/src/qemu/qemu_command.c
Daniel P. Berrange d7239a
+++ b/src/qemu/qemu_command.c
Daniel P. Berrange d7239a
@@ -3173,7 +3173,7 @@ qemuBuildCommandLine(virConnectPtr conn,
Daniel P. Berrange d7239a
         int bootCD = 0, bootFloppy = 0, bootDisk = 0;
Daniel P. Berrange d7239a
 
Daniel P. Berrange d7239a
         /* If QEMU supports boot=on for -drive param... */
Daniel P. Berrange d7239a
-        if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT) {
Daniel P. Berrange d7239a
+        if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT && !def->os.kernel) {
Daniel P. Berrange d7239a
             for (i = 0 ; i < def->os.nBootDevs ; i++) {
Daniel P. Berrange d7239a
                 switch (def->os.bootDevs[i]) {
Daniel P. Berrange d7239a
                 case VIR_DOMAIN_BOOT_CDROM: