From 3d7771e0570e09096ad9391a857dad48b150bc0c Mon Sep 17 00:00:00 2001

From: Mark McLoughlin <markmc@redhat.com>

Date: Wed, 6 May 2009 16:33:28 +0100

Subject: [PATCH] Fix qemu driver's interpretation of <hostdev managed='yes'/>

This change:

  Tue Mar  3 08:55:13 GMT 2009 Daniel P. Berrange <berrange@redhat.com>

       Don't try to detach & reset PCI devices while running test

       suite for XML-> ARGV conversion.

       * src/qemu_driver.c: Add qemuPrepareHostDevices() helper to

       detach and reset PCI devices.

       * src/qemu_conf.c: Don't detach & reset PCI devices while

       building the command line argv

accidentally did this:

-            if (hostdev->managed) {

+        if (!hostdev->managed) {

Which results in managed='yes' not causing the device to be

detached when the guest is starting.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>

---

 src/qemu_driver.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/qemu_driver.c b/src/qemu_driver.c

index 5898026..59312c0 100644

--- a/src/qemu_driver.c

+++ b/src/qemu_driver.c

@@ -1215,7 +1215,7 @@ static int qemuPrepareHostDevices(virConnectPtr conn,

         if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)

             continue;

-        if (!hostdev->managed) {

+        if (hostdev->managed) {

             pciDevice *dev = pciGetDevice(conn,

                                           hostdev->source.subsys.u.pci.domain,

                                           hostdev->source.subsys.u.pci.bus,

-- 

1.6.0.6