|
 |
c313de |
From d1c2f060ea724b4f430f9e3198676e18bf0656af Mon Sep 17 00:00:00 2001
|
|
|
c313de |
Message-Id: <d1c2f060ea724b4f430f9e3198676e18bf0656af@dist-git>
|
|
|
c313de |
From: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
Date: Mon, 1 Jul 2019 17:07:56 +0200
|
|
|
c313de |
Subject: [PATCH] vircgrouptest: introduce initFakeFS and cleanupFakeFS helpers
|
|
|
c313de |
MIME-Version: 1.0
|
|
|
c313de |
Content-Type: text/plain; charset=UTF-8
|
|
|
c313de |
Content-Transfer-Encoding: 8bit
|
|
|
c313de |
|
|
|
c313de |
We need to configure multiple env variables for each set of tests so
|
|
|
c313de |
create helper functions to do that.
|
|
|
c313de |
|
|
|
c313de |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
(cherry picked from commit 9b9c6528a2f867a3be79022b4f282116d2efd3cd)
|
|
|
c313de |
|
|
|
c313de |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
|
|
|
c313de |
|
|
|
c313de |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
c313de |
Message-Id: <b9c0307500ba7b4e95ed097a457590a54dcd0ddb.1561993100.git.phrdina@redhat.com>
|
|
|
c313de |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
c313de |
---
|
|
|
c313de |
tests/vircgrouptest.c | 48 ++++++++++++++++++++++++++++++++-----------
|
|
|
c313de |
1 file changed, 36 insertions(+), 12 deletions(-)
|
|
|
c313de |
|
|
|
c313de |
diff --git a/tests/vircgrouptest.c b/tests/vircgrouptest.c
|
|
|
c313de |
index c4bf987ca1..1837383e61 100644
|
|
|
c313de |
--- a/tests/vircgrouptest.c
|
|
|
c313de |
+++ b/tests/vircgrouptest.c
|
|
|
c313de |
@@ -831,10 +831,10 @@ static int testCgroupGetBlkioIoDeviceServiced(const void *args ATTRIBUTE_UNUSED)
|
|
|
c313de |
|
|
|
c313de |
# define FAKEROOTDIRTEMPLATE abs_builddir "/fakerootdir-XXXXXX"
|
|
|
c313de |
|
|
|
c313de |
-static int
|
|
|
c313de |
-mymain(void)
|
|
|
c313de |
+static char *
|
|
|
c313de |
+initFakeFS(const char *mode,
|
|
|
c313de |
+ const char *filename)
|
|
|
c313de |
{
|
|
|
c313de |
- int ret = 0;
|
|
|
c313de |
char *fakerootdir;
|
|
|
c313de |
|
|
|
c313de |
if (VIR_STRDUP_QUIET(fakerootdir, FAKEROOTDIRTEMPLATE) < 0) {
|
|
|
c313de |
@@ -849,6 +849,33 @@ mymain(void)
|
|
|
c313de |
|
|
|
c313de |
setenv("LIBVIRT_FAKE_ROOT_DIR", fakerootdir, 1);
|
|
|
c313de |
|
|
|
c313de |
+ if (mode)
|
|
|
c313de |
+ setenv("VIR_CGROUP_MOCK_MODE", mode, 1);
|
|
|
c313de |
+
|
|
|
c313de |
+ if (filename)
|
|
|
c313de |
+ setenv("VIR_CGROUP_MOCK_FILENAME", filename, 1);
|
|
|
c313de |
+
|
|
|
c313de |
+ return fakerootdir;
|
|
|
c313de |
+}
|
|
|
c313de |
+
|
|
|
c313de |
+static void
|
|
|
c313de |
+cleanupFakeFS(char *fakerootdir)
|
|
|
c313de |
+{
|
|
|
c313de |
+ if (getenv("LIBVIRT_SKIP_CLEANUP") == NULL)
|
|
|
c313de |
+ virFileDeleteTree(fakerootdir);
|
|
|
c313de |
+
|
|
|
c313de |
+ VIR_FREE(fakerootdir);
|
|
|
c313de |
+ unsetenv("LIBVIRT_FAKE_ROOT_DIR");
|
|
|
c313de |
+ unsetenv("VIR_CGROUP_MOCK_MODE");
|
|
|
c313de |
+ unsetenv("VIR_CGROUP_MOCK_FILENAME");
|
|
|
c313de |
+}
|
|
|
c313de |
+
|
|
|
c313de |
+static int
|
|
|
c313de |
+mymain(void)
|
|
|
c313de |
+{
|
|
|
c313de |
+ int ret = 0;
|
|
|
c313de |
+ char *fakerootdir;
|
|
|
c313de |
+
|
|
|
c313de |
# define DETECT_MOUNTS_FULL(file, fail) \
|
|
|
c313de |
do { \
|
|
|
c313de |
struct _detectMountsData data = { file, fail }; \
|
|
|
c313de |
@@ -872,7 +899,7 @@ mymain(void)
|
|
|
c313de |
DETECT_MOUNTS_FAIL("no-cgroups");
|
|
|
c313de |
DETECT_MOUNTS("kubevirt");
|
|
|
c313de |
|
|
|
c313de |
- setenv("VIR_CGROUP_MOCK_FILENAME", "systemd", 1);
|
|
|
c313de |
+ fakerootdir = initFakeFS(NULL, "systemd");
|
|
|
c313de |
if (virTestRun("New cgroup for self", testCgroupNewForSelf, NULL) < 0)
|
|
|
c313de |
ret = -1;
|
|
|
c313de |
|
|
|
c313de |
@@ -908,26 +935,23 @@ mymain(void)
|
|
|
c313de |
|
|
|
c313de |
if (virTestRun("virCgroupGetPercpuStats works", testCgroupGetPercpuStats, NULL) < 0)
|
|
|
c313de |
ret = -1;
|
|
|
c313de |
- unsetenv("VIR_CGROUP_MOCK_FILENAME");
|
|
|
c313de |
+ cleanupFakeFS(fakerootdir);
|
|
|
c313de |
|
|
|
c313de |
- setenv("VIR_CGROUP_MOCK_FILENAME", "all-in-one", 1);
|
|
|
c313de |
+ fakerootdir = initFakeFS(NULL, "all-in-one");
|
|
|
c313de |
if (virTestRun("New cgroup for self (allinone)", testCgroupNewForSelfAllInOne, NULL) < 0)
|
|
|
c313de |
ret = -1;
|
|
|
c313de |
if (virTestRun("Cgroup available", testCgroupAvailable, (void*)0x1) < 0)
|
|
|
c313de |
ret = -1;
|
|
|
c313de |
- unsetenv("VIR_CGROUP_MOCK_FILENAME");
|
|
|
c313de |
+ cleanupFakeFS(fakerootdir);
|
|
|
c313de |
|
|
|
c313de |
- setenv("VIR_CGROUP_MOCK_FILENAME", "logind", 1);
|
|
|
c313de |
+ fakerootdir = initFakeFS(NULL, "logind");
|
|
|
c313de |
if (virTestRun("New cgroup for self (logind)", testCgroupNewForSelfLogind, NULL) < 0)
|
|
|
c313de |
ret = -1;
|
|
|
c313de |
if (virTestRun("Cgroup available", testCgroupAvailable, (void*)0x0) < 0)
|
|
|
c313de |
ret = -1;
|
|
|
c313de |
- unsetenv("VIR_CGROUP_MOCK_FILENAME");
|
|
|
c313de |
+ cleanupFakeFS(fakerootdir);
|
|
|
c313de |
|
|
|
c313de |
- if (getenv("LIBVIRT_SKIP_CLEANUP") == NULL)
|
|
|
c313de |
- virFileDeleteTree(fakerootdir);
|
|
|
c313de |
|
|
|
c313de |
- VIR_FREE(fakerootdir);
|
|
|
c313de |
|
|
|
c313de |
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
|
c313de |
}
|
|
|
c313de |
--
|
|
|
c313de |
2.22.0
|
|
|
c313de |
|