render / rpms / libvirt

Forked from rpms/libvirt 9 months ago
Clone
99cbc7
From 191c1124fbdd06f1b7a6f214ebdc927f17349892 Mon Sep 17 00:00:00 2001
99cbc7
Message-Id: <191c1124fbdd06f1b7a6f214ebdc927f17349892@dist-git>
99cbc7
From: Pavel Hrdina <phrdina@redhat.com>
99cbc7
Date: Mon, 13 Aug 2018 18:16:13 +0200
99cbc7
Subject: [PATCH] tests: rename hugepages-pages4 into
99cbc7
 hugepages-numa-nodeset-nonexist
99cbc7
MIME-Version: 1.0
99cbc7
Content-Type: text/plain; charset=UTF-8
99cbc7
Content-Transfer-Encoding: 8bit
99cbc7
99cbc7
Remove unnecessary XML elements as well.
99cbc7
99cbc7
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
99cbc7
(cherry picked from commit 5534edcb9e0cd462f2bae8acb92bd9b85aa874f0)
99cbc7
99cbc7
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591235
99cbc7
99cbc7
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
99cbc7
Reviewed-by: Ján Tomko <jtomko@redhat.com>
99cbc7
---
99cbc7
 ....xml => hugepages-numa-nodeset-nonexist.xml} | 17 +----------------
99cbc7
 tests/qemuxml2argvtest.c                        |  5 +++--
99cbc7
 .../hugepages-numa-nodeset-nonexist.xml         |  1 +
99cbc7
 tests/qemuxml2xmloutdata/hugepages-pages4.xml   |  1 -
99cbc7
 tests/qemuxml2xmltest.c                         |  2 +-
99cbc7
 5 files changed, 6 insertions(+), 20 deletions(-)
99cbc7
 rename tests/qemuxml2argvdata/{hugepages-pages4.xml => hugepages-numa-nodeset-nonexist.xml} (66%)
99cbc7
 create mode 120000 tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml
99cbc7
 delete mode 120000 tests/qemuxml2xmloutdata/hugepages-pages4.xml
99cbc7
99cbc7
diff --git a/tests/qemuxml2argvdata/hugepages-pages4.xml b/tests/qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
99cbc7
similarity index 66%
99cbc7
rename from tests/qemuxml2argvdata/hugepages-pages4.xml
99cbc7
rename to tests/qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
99cbc7
index 9f79881a59..8211d72be9 100644
99cbc7
--- a/tests/qemuxml2argvdata/hugepages-pages4.xml
99cbc7
+++ b/tests/qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
99cbc7
@@ -10,10 +10,6 @@
99cbc7
     </hugepages>
99cbc7
   </memoryBacking>
99cbc7
   <vcpu placement='static'>4</vcpu>
99cbc7
-  <numatune>
99cbc7
-    <memory mode='strict' nodeset='0-3'/>
99cbc7
-    <memnode cellid='3' mode='strict' nodeset='3'/>
99cbc7
-  </numatune>
99cbc7
   <os>
99cbc7
     <type arch='i686' machine='pc'>hvm</type>
99cbc7
     <boot dev='hd'/>
99cbc7
@@ -32,23 +28,12 @@
99cbc7
   <on_crash>destroy</on_crash>
99cbc7
   <devices>
99cbc7
     <emulator>/usr/bin/qemu-system-i686</emulator>
99cbc7
-    <disk type='block' device='disk'>
99cbc7
-      <driver name='qemu' type='raw'/>
99cbc7
-      <source dev='/dev/HostVG/QEMUGuest1'/>
99cbc7
-      <target dev='hda' bus='ide'/>
99cbc7
-      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
99cbc7
-    </disk>
99cbc7
     <controller type='usb' index='0'>
99cbc7
       <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
99cbc7
     </controller>
99cbc7
-    <controller type='ide' index='0'>
99cbc7
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
99cbc7
-    </controller>
99cbc7
     <controller type='pci' index='0' model='pci-root'/>
99cbc7
     <input type='mouse' bus='ps2'/>
99cbc7
     <input type='keyboard' bus='ps2'/>
99cbc7
-    <memballoon model='virtio'>
99cbc7
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
99cbc7
-    </memballoon>
99cbc7
+    <memballoon model='none'/>
99cbc7
   </devices>
99cbc7
 </domain>
99cbc7
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
99cbc7
index 5a41bbe6e0..1b6e8ded43 100644
99cbc7
--- a/tests/qemuxml2argvtest.c
99cbc7
+++ b/tests/qemuxml2argvtest.c
99cbc7
@@ -967,12 +967,13 @@ mymain(void)
99cbc7
     DO_TEST("hugepages-numa-nodeset-part",
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_RAM,
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
+    DO_TEST_FAILURE("hugepages-numa-nodeset-nonexist",
99cbc7
+                    QEMU_CAPS_OBJECT_MEMORY_RAM,
99cbc7
+                    QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
     DO_TEST("hugepages-shared",
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_RAM,
99cbc7
             QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
     DO_TEST_PARSE_ERROR("hugepages-memaccess-invalid", NONE);
99cbc7
-    DO_TEST_FAILURE("hugepages-pages4",
99cbc7
-            QEMU_CAPS_OBJECT_MEMORY_RAM, QEMU_CAPS_OBJECT_MEMORY_FILE);
99cbc7
     DO_TEST("hugepages-pages5", NONE);
99cbc7
     DO_TEST("hugepages-pages6", NONE);
99cbc7
     DO_TEST("hugepages-pages7",
99cbc7
diff --git a/tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml b/tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml
99cbc7
new file mode 120000
99cbc7
index 0000000000..d490edca69
99cbc7
--- /dev/null
99cbc7
+++ b/tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml
99cbc7
@@ -0,0 +1 @@
99cbc7
+../qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
99cbc7
\ No newline at end of file
99cbc7
diff --git a/tests/qemuxml2xmloutdata/hugepages-pages4.xml b/tests/qemuxml2xmloutdata/hugepages-pages4.xml
99cbc7
deleted file mode 120000
99cbc7
index 127e66e64f..0000000000
99cbc7
--- a/tests/qemuxml2xmloutdata/hugepages-pages4.xml
99cbc7
+++ /dev/null
99cbc7
@@ -1 +0,0 @@
99cbc7
-../qemuxml2argvdata/hugepages-pages4.xml
99cbc7
\ No newline at end of file
99cbc7
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
99cbc7
index bb7b0ce481..9b3152821f 100644
99cbc7
--- a/tests/qemuxml2xmltest.c
99cbc7
+++ b/tests/qemuxml2xmltest.c
99cbc7
@@ -337,7 +337,7 @@ mymain(void)
99cbc7
     DO_TEST("hugepages-numa-default-dimm", NONE);
99cbc7
     DO_TEST("hugepages-numa-nodeset", NONE);
99cbc7
     DO_TEST("hugepages-numa-nodeset-part", NONE);
99cbc7
-    DO_TEST("hugepages-pages4", NONE);
99cbc7
+    DO_TEST("hugepages-numa-nodeset-nonexist", NONE);
99cbc7
     DO_TEST("hugepages-pages5", NONE);
99cbc7
     DO_TEST("hugepages-pages6", NONE);
99cbc7
     DO_TEST("hugepages-pages7", NONE);
99cbc7
-- 
99cbc7
2.18.0
99cbc7