render / rpms / libvirt

Forked from rpms/libvirt 10 months ago
Clone
982648
From 191c1124fbdd06f1b7a6f214ebdc927f17349892 Mon Sep 17 00:00:00 2001
982648
Message-Id: <191c1124fbdd06f1b7a6f214ebdc927f17349892@dist-git>
982648
From: Pavel Hrdina <phrdina@redhat.com>
982648
Date: Mon, 13 Aug 2018 18:16:13 +0200
982648
Subject: [PATCH] tests: rename hugepages-pages4 into
982648
 hugepages-numa-nodeset-nonexist
982648
MIME-Version: 1.0
982648
Content-Type: text/plain; charset=UTF-8
982648
Content-Transfer-Encoding: 8bit
982648
982648
Remove unnecessary XML elements as well.
982648
982648
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
982648
(cherry picked from commit 5534edcb9e0cd462f2bae8acb92bd9b85aa874f0)
982648
982648
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591235
982648
982648
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
982648
Reviewed-by: Ján Tomko <jtomko@redhat.com>
982648
---
982648
 ....xml => hugepages-numa-nodeset-nonexist.xml} | 17 +----------------
982648
 tests/qemuxml2argvtest.c                        |  5 +++--
982648
 .../hugepages-numa-nodeset-nonexist.xml         |  1 +
982648
 tests/qemuxml2xmloutdata/hugepages-pages4.xml   |  1 -
982648
 tests/qemuxml2xmltest.c                         |  2 +-
982648
 5 files changed, 6 insertions(+), 20 deletions(-)
982648
 rename tests/qemuxml2argvdata/{hugepages-pages4.xml => hugepages-numa-nodeset-nonexist.xml} (66%)
982648
 create mode 120000 tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml
982648
 delete mode 120000 tests/qemuxml2xmloutdata/hugepages-pages4.xml
982648
982648
diff --git a/tests/qemuxml2argvdata/hugepages-pages4.xml b/tests/qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
982648
similarity index 66%
982648
rename from tests/qemuxml2argvdata/hugepages-pages4.xml
982648
rename to tests/qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
982648
index 9f79881a59..8211d72be9 100644
982648
--- a/tests/qemuxml2argvdata/hugepages-pages4.xml
982648
+++ b/tests/qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
982648
@@ -10,10 +10,6 @@
982648
     </hugepages>
982648
   </memoryBacking>
982648
   <vcpu placement='static'>4</vcpu>
982648
-  <numatune>
982648
-    <memory mode='strict' nodeset='0-3'/>
982648
-    <memnode cellid='3' mode='strict' nodeset='3'/>
982648
-  </numatune>
982648
   <os>
982648
     <type arch='i686' machine='pc'>hvm</type>
982648
     <boot dev='hd'/>
982648
@@ -32,23 +28,12 @@
982648
   <on_crash>destroy</on_crash>
982648
   <devices>
982648
     <emulator>/usr/bin/qemu-system-i686</emulator>
982648
-    <disk type='block' device='disk'>
982648
-      <driver name='qemu' type='raw'/>
982648
-      <source dev='/dev/HostVG/QEMUGuest1'/>
982648
-      <target dev='hda' bus='ide'/>
982648
-      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
982648
-    </disk>
982648
     <controller type='usb' index='0'>
982648
       <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
982648
     </controller>
982648
-    <controller type='ide' index='0'>
982648
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
982648
-    </controller>
982648
     <controller type='pci' index='0' model='pci-root'/>
982648
     <input type='mouse' bus='ps2'/>
982648
     <input type='keyboard' bus='ps2'/>
982648
-    <memballoon model='virtio'>
982648
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
982648
-    </memballoon>
982648
+    <memballoon model='none'/>
982648
   </devices>
982648
 </domain>
982648
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
982648
index 5a41bbe6e0..1b6e8ded43 100644
982648
--- a/tests/qemuxml2argvtest.c
982648
+++ b/tests/qemuxml2argvtest.c
982648
@@ -967,12 +967,13 @@ mymain(void)
982648
     DO_TEST("hugepages-numa-nodeset-part",
982648
             QEMU_CAPS_OBJECT_MEMORY_RAM,
982648
             QEMU_CAPS_OBJECT_MEMORY_FILE);
982648
+    DO_TEST_FAILURE("hugepages-numa-nodeset-nonexist",
982648
+                    QEMU_CAPS_OBJECT_MEMORY_RAM,
982648
+                    QEMU_CAPS_OBJECT_MEMORY_FILE);
982648
     DO_TEST("hugepages-shared",
982648
             QEMU_CAPS_OBJECT_MEMORY_RAM,
982648
             QEMU_CAPS_OBJECT_MEMORY_FILE);
982648
     DO_TEST_PARSE_ERROR("hugepages-memaccess-invalid", NONE);
982648
-    DO_TEST_FAILURE("hugepages-pages4",
982648
-            QEMU_CAPS_OBJECT_MEMORY_RAM, QEMU_CAPS_OBJECT_MEMORY_FILE);
982648
     DO_TEST("hugepages-pages5", NONE);
982648
     DO_TEST("hugepages-pages6", NONE);
982648
     DO_TEST("hugepages-pages7",
982648
diff --git a/tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml b/tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml
982648
new file mode 120000
982648
index 0000000000..d490edca69
982648
--- /dev/null
982648
+++ b/tests/qemuxml2xmloutdata/hugepages-numa-nodeset-nonexist.xml
982648
@@ -0,0 +1 @@
982648
+../qemuxml2argvdata/hugepages-numa-nodeset-nonexist.xml
982648
\ No newline at end of file
982648
diff --git a/tests/qemuxml2xmloutdata/hugepages-pages4.xml b/tests/qemuxml2xmloutdata/hugepages-pages4.xml
982648
deleted file mode 120000
982648
index 127e66e64f..0000000000
982648
--- a/tests/qemuxml2xmloutdata/hugepages-pages4.xml
982648
+++ /dev/null
982648
@@ -1 +0,0 @@
982648
-../qemuxml2argvdata/hugepages-pages4.xml
982648
\ No newline at end of file
982648
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
982648
index bb7b0ce481..9b3152821f 100644
982648
--- a/tests/qemuxml2xmltest.c
982648
+++ b/tests/qemuxml2xmltest.c
982648
@@ -337,7 +337,7 @@ mymain(void)
982648
     DO_TEST("hugepages-numa-default-dimm", NONE);
982648
     DO_TEST("hugepages-numa-nodeset", NONE);
982648
     DO_TEST("hugepages-numa-nodeset-part", NONE);
982648
-    DO_TEST("hugepages-pages4", NONE);
982648
+    DO_TEST("hugepages-numa-nodeset-nonexist", NONE);
982648
     DO_TEST("hugepages-pages5", NONE);
982648
     DO_TEST("hugepages-pages6", NONE);
982648
     DO_TEST("hugepages-pages7", NONE);
982648
-- 
982648
2.18.0
982648