render / rpms / libvirt

Forked from rpms/libvirt 9 months ago
Clone
fbe740
From ec3392c1d5a9886279ee086ee3d421106b9b1e32 Mon Sep 17 00:00:00 2001
fbe740
Message-Id: <ec3392c1d5a9886279ee086ee3d421106b9b1e32@dist-git>
fbe740
From: Peter Krempa <pkrempa@redhat.com>
fbe740
Date: Mon, 16 Mar 2020 22:12:18 +0100
fbe740
Subject: [PATCH] qemuCheckpointDiscardBitmaps: Use correct field for
fbe740
 checkpoint bitmap name
fbe740
MIME-Version: 1.0
fbe740
Content-Type: text/plain; charset=UTF-8
fbe740
Content-Transfer-Encoding: 8bit
fbe740
fbe740
The code deleting checkpoints needs the name of the parent checkpoint's
fbe740
disk's bitmap but was using the disk alias instead. This would create
fbe740
wrong bitmaps after deleting some checkpoints.
fbe740
fbe740
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
fbe740
Reviewed-by: Eric Blake <eblake@redhat.com>
fbe740
(cherry picked from commit 0ce8b0fbe2d0cbaf26da0402270720b776ebfb0f)
fbe740
https://bugzilla.redhat.com/show_bug.cgi?id=1799013
fbe740
Message-Id: <c32db1af44e71870d172233acdfddf050ed73441.1584391727.git.pkrempa@redhat.com>
fbe740
Reviewed-by: Ján Tomko <jtomko@redhat.com>
fbe740
---
fbe740
 src/qemu/qemu_checkpoint.c | 2 +-
fbe740
 1 file changed, 1 insertion(+), 1 deletion(-)
fbe740
fbe740
diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
fbe740
index 6e3a432022..19822bd74d 100644
fbe740
--- a/src/qemu/qemu_checkpoint.c
fbe740
+++ b/src/qemu/qemu_checkpoint.c
fbe740
@@ -285,7 +285,7 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
fbe740
          * ancestor. */
fbe740
         if ((parentchkdisk = qemuCheckpointFindActiveDiskInParent(vm, parent,
fbe740
                                                                   chkdisk->name)))
fbe740
-            parentbitmap = parentchkdisk->name;
fbe740
+            parentbitmap = parentchkdisk->bitmap;
fbe740
 
fbe740
         if (qemuCheckpointDiscardDiskBitmaps(domdisk->src, blockNamedNodeData,
fbe740
                                              chkdisk->bitmap, parentbitmap,
fbe740
-- 
fbe740
2.25.1
fbe740