|
 |
fbe740 |
From 2d27c71da092e9232c2d79738a431c04db649a96 Mon Sep 17 00:00:00 2001
|
|
|
fbe740 |
Message-Id: <2d27c71da092e9232c2d79738a431c04db649a96@dist-git>
|
|
|
fbe740 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Date: Mon, 30 Mar 2020 17:21:46 +0200
|
|
|
fbe740 |
Subject: [PATCH] qemuBlockStorageSourceGetURI: Pass through query component
|
|
|
fbe740 |
MIME-Version: 1.0
|
|
|
fbe740 |
Content-Type: text/plain; charset=UTF-8
|
|
|
fbe740 |
Content-Transfer-Encoding: 8bit
|
|
|
fbe740 |
|
|
|
fbe740 |
If the storage source has the query part set, format it in the output.
|
|
|
fbe740 |
|
|
|
fbe740 |
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
fbe740 |
(cherry picked from commit 216860dd8b93c7da4d625055cf353e0eedda6093)
|
|
|
fbe740 |
https://bugzilla.redhat.com/show_bug.cgi?id=1804750
|
|
|
fbe740 |
Message-Id: <832f573fd69341b7d730925c9df5b23e5f168408.1585581552.git.pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
fbe740 |
---
|
|
|
fbe740 |
src/qemu/qemu_block.c | 2 ++
|
|
|
fbe740 |
src/qemu/qemu_domain.c | 9 +++++++++
|
|
|
fbe740 |
tests/qemuxml2argvdata/disk-cdrom-network.args | 4 ++--
|
|
|
fbe740 |
.../disk-cdrom-network.x86_64-2.12.0.args | 4 ++--
|
|
|
fbe740 |
.../disk-cdrom-network.x86_64-latest.args | 3 ++-
|
|
|
fbe740 |
tests/qemuxml2argvdata/disk-cdrom-network.xml | 2 +-
|
|
|
fbe740 |
.../disk-network-http.x86_64-latest.args | 5 +++--
|
|
|
fbe740 |
7 files changed, 21 insertions(+), 8 deletions(-)
|
|
|
fbe740 |
|
|
|
fbe740 |
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
|
|
|
fbe740 |
index e7577c1312..6790f05ff7 100644
|
|
|
fbe740 |
--- a/src/qemu/qemu_block.c
|
|
|
fbe740 |
+++ b/src/qemu/qemu_block.c
|
|
|
fbe740 |
@@ -437,6 +437,8 @@ qemuBlockStorageSourceGetURI(virStorageSourcePtr src)
|
|
|
fbe740 |
}
|
|
|
fbe740 |
}
|
|
|
fbe740 |
|
|
|
fbe740 |
+ uri->query = g_strdup(src->query);
|
|
|
fbe740 |
+
|
|
|
fbe740 |
uri->server = g_strdup(src->hosts->name);
|
|
|
fbe740 |
|
|
|
fbe740 |
return g_steal_pointer(&uri);
|
|
|
fbe740 |
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
|
|
|
fbe740 |
index 4007b4dbda..bb28716ff0 100644
|
|
|
fbe740 |
--- a/src/qemu/qemu_domain.c
|
|
|
fbe740 |
+++ b/src/qemu/qemu_domain.c
|
|
|
fbe740 |
@@ -7107,6 +7107,15 @@ qemuDomainValidateStorageSource(virStorageSourcePtr src,
|
|
|
fbe740 |
}
|
|
|
fbe740 |
}
|
|
|
fbe740 |
|
|
|
fbe740 |
+ if (src->query &&
|
|
|
fbe740 |
+ (actualType != VIR_STORAGE_TYPE_NETWORK ||
|
|
|
fbe740 |
+ (src->protocol != VIR_STORAGE_NET_PROTOCOL_HTTPS &&
|
|
|
fbe740 |
+ src->protocol != VIR_STORAGE_NET_PROTOCOL_HTTP))) {
|
|
|
fbe740 |
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
|
|
fbe740 |
+ _("query is supported only with HTTP(S) protocols"));
|
|
|
fbe740 |
+ return -1;
|
|
|
fbe740 |
+ }
|
|
|
fbe740 |
+
|
|
|
fbe740 |
return 0;
|
|
|
fbe740 |
}
|
|
|
fbe740 |
|
|
|
fbe740 |
diff --git a/tests/qemuxml2argvdata/disk-cdrom-network.args b/tests/qemuxml2argvdata/disk-cdrom-network.args
|
|
|
fbe740 |
index be19bad68a..81ff324a0f 100644
|
|
|
fbe740 |
--- a/tests/qemuxml2argvdata/disk-cdrom-network.args
|
|
|
fbe740 |
+++ b/tests/qemuxml2argvdata/disk-cdrom-network.args
|
|
|
fbe740 |
@@ -30,8 +30,8 @@ id=drive-ide0-0-0,readonly=on \
|
|
|
fbe740 |
-drive file=ftps://host.name:990/url/path/file.iso,format=raw,if=none,\
|
|
|
fbe740 |
id=drive-ide0-0-1,readonly=on \
|
|
|
fbe740 |
-device ide-cd,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1 \
|
|
|
fbe740 |
--drive file=https://host.name:443/url/path/file.iso,format=raw,if=none,\
|
|
|
fbe740 |
-id=drive-ide0-1-0,readonly=on \
|
|
|
fbe740 |
+-drive 'file=https://host.name:443/url/path/file.iso?test=val,format=raw,\
|
|
|
fbe740 |
+if=none,id=drive-ide0-1-0,readonly=on' \
|
|
|
fbe740 |
-device ide-cd,bus=ide.1,unit=0,drive=drive-ide0-1-0,id=ide0-1-0 \
|
|
|
fbe740 |
-drive file=tftp://host.name:69/url/path/file.iso,format=raw,if=none,\
|
|
|
fbe740 |
id=drive-ide0-1-1,readonly=on \
|
|
|
fbe740 |
diff --git a/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-2.12.0.args b/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-2.12.0.args
|
|
|
fbe740 |
index 1ece3d6f46..81f6b400aa 100644
|
|
|
fbe740 |
--- a/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-2.12.0.args
|
|
|
fbe740 |
+++ b/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-2.12.0.args
|
|
|
fbe740 |
@@ -32,8 +32,8 @@ id=drive-ide0-0-0,readonly=on \
|
|
|
fbe740 |
-drive file=ftps://host.name:990/url/path/file.iso,format=raw,if=none,\
|
|
|
fbe740 |
id=drive-ide0-0-1,readonly=on \
|
|
|
fbe740 |
-device ide-cd,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1 \
|
|
|
fbe740 |
--drive file=https://host.name:443/url/path/file.iso,format=raw,if=none,\
|
|
|
fbe740 |
-id=drive-ide0-1-0,readonly=on \
|
|
|
fbe740 |
+-drive 'file=https://host.name:443/url/path/file.iso?test=val,format=raw,\
|
|
|
fbe740 |
+if=none,id=drive-ide0-1-0,readonly=on' \
|
|
|
fbe740 |
-device ide-cd,bus=ide.1,unit=0,drive=drive-ide0-1-0,id=ide0-1-0 \
|
|
|
fbe740 |
-drive file=tftp://host.name:69/url/path/file.iso,format=raw,if=none,\
|
|
|
fbe740 |
id=drive-ide0-1-1,readonly=on \
|
|
|
fbe740 |
diff --git a/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-latest.args b/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-latest.args
|
|
|
fbe740 |
index 0b4ac07f07..2515b256d0 100644
|
|
|
fbe740 |
--- a/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-latest.args
|
|
|
fbe740 |
+++ b/tests/qemuxml2argvdata/disk-cdrom-network.x86_64-latest.args
|
|
|
fbe740 |
@@ -37,7 +37,8 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
|
|
|
fbe740 |
-blockdev '{"node-name":"libvirt-3-format","read-only":true,"driver":"raw",\
|
|
|
fbe740 |
"file":"libvirt-3-storage"}' \
|
|
|
fbe740 |
-device ide-cd,bus=ide.0,unit=1,drive=libvirt-3-format,id=ide0-0-1 \
|
|
|
fbe740 |
--blockdev '{"driver":"https","url":"https://host.name:443/url/path/file.iso",\
|
|
|
fbe740 |
+-blockdev '{"driver":"https",\
|
|
|
fbe740 |
+"url":"https://host.name:443/url/path/file.iso?test=val",\
|
|
|
fbe740 |
"node-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap"}' \
|
|
|
fbe740 |
-blockdev '{"node-name":"libvirt-2-format","read-only":true,"driver":"raw",\
|
|
|
fbe740 |
"file":"libvirt-2-storage"}' \
|
|
|
fbe740 |
diff --git a/tests/qemuxml2argvdata/disk-cdrom-network.xml b/tests/qemuxml2argvdata/disk-cdrom-network.xml
|
|
|
fbe740 |
index 0bdc0e1883..44473f8ad4 100644
|
|
|
fbe740 |
--- a/tests/qemuxml2argvdata/disk-cdrom-network.xml
|
|
|
fbe740 |
+++ b/tests/qemuxml2argvdata/disk-cdrom-network.xml
|
|
|
fbe740 |
@@ -39,7 +39,7 @@
|
|
|
fbe740 |
</disk>
|
|
|
fbe740 |
<disk type='network' device='cdrom'>
|
|
|
fbe740 |
<driver name='qemu' type='raw'/>
|
|
|
fbe740 |
- <source protocol='https' name='/url/path/file.iso'>
|
|
|
fbe740 |
+ <source protocol='https' name='/url/path/file.iso' query='test=val'>
|
|
|
fbe740 |
<host name='host.name' port='443'/>
|
|
|
fbe740 |
</source>
|
|
|
fbe740 |
<target dev='hdc' bus='ide'/>
|
|
|
fbe740 |
diff --git a/tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args b/tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args
|
|
|
fbe740 |
index 46aa5f23ce..d1bf0b9caa 100644
|
|
|
fbe740 |
--- a/tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args
|
|
|
fbe740 |
+++ b/tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args
|
|
|
fbe740 |
@@ -54,8 +54,9 @@ id=virtio-disk2 \
|
|
|
fbe740 |
-object secret,id=libvirt-1-storage-httpcookie-secret0,\
|
|
|
fbe740 |
data=DrPR9NA6GKJb7qi1KbjHaealKEMVtOWUl2h3yvO5lgIh6cyLHemmlg+h9fcgwREA,\
|
|
|
fbe740 |
keyid=masterKey0,iv=AAECAwQFBgcICQoLDA0ODw==,format=base64 \
|
|
|
fbe740 |
--blockdev '{"driver":"https","url":"https://example.org:1234/test4.img",\
|
|
|
fbe740 |
-"sslverify":false,"cookie-secret":"libvirt-1-storage-httpcookie-secret0",\
|
|
|
fbe740 |
+-blockdev '{"driver":"https",\
|
|
|
fbe740 |
+"url":"https://example.org:1234/test4.img?par=val&other=ble","sslverify":false,\
|
|
|
fbe740 |
+"cookie-secret":"libvirt-1-storage-httpcookie-secret0",\
|
|
|
fbe740 |
"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \
|
|
|
fbe740 |
-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"raw",\
|
|
|
fbe740 |
"file":"libvirt-1-storage"}' \
|
|
|
fbe740 |
--
|
|
|
fbe740 |
2.26.0
|
|
|
fbe740 |
|