|
 |
fbe740 |
From 60d5a8463c380b005f16698bca7b38c11b122e03 Mon Sep 17 00:00:00 2001
|
|
|
fbe740 |
Message-Id: <60d5a8463c380b005f16698bca7b38c11b122e03@dist-git>
|
|
|
fbe740 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Date: Tue, 17 Mar 2020 17:12:45 +0100
|
|
|
fbe740 |
Subject: [PATCH] qemuBlockBitmapsHandleCommitFinish: Use proper variable to
|
|
|
fbe740 |
iterate
|
|
|
fbe740 |
MIME-Version: 1.0
|
|
|
fbe740 |
Content-Type: text/plain; charset=UTF-8
|
|
|
fbe740 |
Content-Transfer-Encoding: 8bit
|
|
|
fbe740 |
|
|
|
fbe740 |
The function repeatedly checked the first element rather than iterating
|
|
|
fbe740 |
through the array.
|
|
|
fbe740 |
|
|
|
fbe740 |
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
fbe740 |
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
fbe740 |
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
fbe740 |
(cherry picked from commit 7a16318855811ac4ae55d30b77969528099fd180)
|
|
|
fbe740 |
https://bugzilla.redhat.com/show_bug.cgi?id=1799013
|
|
|
fbe740 |
Message-Id: <25addb80a3899e5789c32aecab8184066e80cbd0.1584461519.git.pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
fbe740 |
---
|
|
|
fbe740 |
src/qemu/qemu_block.c | 2 +-
|
|
|
fbe740 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
fbe740 |
|
|
|
fbe740 |
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
|
|
|
fbe740 |
index dad3e2317f..73cb5ba4bc 100644
|
|
|
fbe740 |
--- a/src/qemu/qemu_block.c
|
|
|
fbe740 |
+++ b/src/qemu/qemu_block.c
|
|
|
fbe740 |
@@ -3175,7 +3175,7 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSourcePtr topsrc,
|
|
|
fbe740 |
char **disabledbitmaps;
|
|
|
fbe740 |
|
|
|
fbe740 |
for (disabledbitmaps = disabledBitmapsBase; *disabledbitmaps; disabledbitmaps++) {
|
|
|
fbe740 |
- if (STREQ(*disabledBitmapsBase, bitmap->name)) {
|
|
|
fbe740 |
+ if (STREQ(*disabledbitmaps, bitmap->name)) {
|
|
|
fbe740 |
bitmapdata = g_new0(struct qemuBlockBitmapsHandleCommitData, 1);
|
|
|
fbe740 |
|
|
|
fbe740 |
bitmapdata->create = false;
|
|
|
fbe740 |
--
|
|
|
fbe740 |
2.25.1
|
|
|
fbe740 |
|