|
 |
acda74 |
From d0f4b44754db733db8a180aa18c06bb17dd21b1a Mon Sep 17 00:00:00 2001
|
|
|
acda74 |
Message-Id: <d0f4b44754db733db8a180aa18c06bb17dd21b1a@dist-git>
|
|
|
acda74 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
acda74 |
Date: Wed, 1 Mar 2023 17:09:42 +0100
|
|
|
acda74 |
Subject: [PATCH] qemu: domain: Fix logic when tainting domain
|
|
|
acda74 |
|
|
|
acda74 |
Originally the code was skipping all repeated taints with the same taint
|
|
|
acda74 |
flag but a logic bug introduced in commit 30626ed15b239c424ae inverted
|
|
|
acda74 |
the condition. This caused that actually the first occurence was NOT
|
|
|
acda74 |
logged but any subsequent was.
|
|
|
acda74 |
|
|
|
acda74 |
This was noticed when going through oVirt logs as they use custom guest
|
|
|
acda74 |
agent commands and the logs are totally spammed with this message.
|
|
|
acda74 |
|
|
|
acda74 |
Fixes: 30626ed15b239c424ae891f096057a696eadd715
|
|
|
acda74 |
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
acda74 |
Reviewed-by: Laine Stump <laine@redhat.com>
|
|
|
acda74 |
(cherry picked from commit 9134b40d0b43a5e1a9928b0a0d948205941d9807)
|
|
|
acda74 |
https://bugzilla.redhat.com/show_bug.cgi?id=2174446
|
|
|
acda74 |
---
|
|
|
acda74 |
src/qemu/qemu_domain.c | 2 +-
|
|
|
acda74 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
acda74 |
|
|
|
acda74 |
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
|
|
|
acda74 |
index 26408b90a2..374b881146 100644
|
|
|
acda74 |
--- a/src/qemu/qemu_domain.c
|
|
|
acda74 |
+++ b/src/qemu/qemu_domain.c
|
|
|
acda74 |
@@ -6591,7 +6591,7 @@ void qemuDomainObjTaintMsg(virQEMUDriver *driver,
|
|
|
acda74 |
const char *extrasuffix = "";
|
|
|
acda74 |
va_list args;
|
|
|
acda74 |
|
|
|
acda74 |
- if (virDomainObjTaint(obj, taint)) {
|
|
|
acda74 |
+ if (!virDomainObjTaint(obj, taint)) {
|
|
|
acda74 |
/* If an extra message was given we must always
|
|
|
acda74 |
* emit the taint warning, otherwise it is a
|
|
|
acda74 |
* one-time only warning per VM
|
|
|
acda74 |
--
|
|
|
acda74 |
2.39.2
|
|
|
acda74 |
|