|
 |
fbe740 |
From 627b980c628dd06fb9995e83130fbaa858d4087f Mon Sep 17 00:00:00 2001
|
|
|
fbe740 |
Message-Id: <627b980c628dd06fb9995e83130fbaa858d4087f@dist-git>
|
|
|
fbe740 |
From: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Date: Fri, 28 Feb 2020 10:24:42 +0100
|
|
|
fbe740 |
Subject: [PATCH] qemu: domain: Convert detected 'iso' image format into 'raw'
|
|
|
fbe740 |
MIME-Version: 1.0
|
|
|
fbe740 |
Content-Type: text/plain; charset=UTF-8
|
|
|
fbe740 |
Content-Transfer-Encoding: 8bit
|
|
|
fbe740 |
|
|
|
fbe740 |
While our code can detect ISO as a separate format, qemu does not use it
|
|
|
fbe740 |
as such and just passes it through as raw. Add conversion for detected
|
|
|
fbe740 |
parts of the backing chain so that the validation code does not reject
|
|
|
fbe740 |
it right away.
|
|
|
fbe740 |
|
|
|
fbe740 |
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
fbe740 |
(cherry picked from commit 3c6e6f55a5ded357c39b92629cd523e51f6ca8f9)
|
|
|
fbe740 |
|
|
|
fbe740 |
https://bugzilla.redhat.com/show_bug.cgi?id=1798148
|
|
|
fbe740 |
Message-Id: <2c6cfa942acf0d7fe56046122b23780ee5c0d777.1582881363.git.pkrempa@redhat.com>
|
|
|
fbe740 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
fbe740 |
---
|
|
|
fbe740 |
src/qemu/qemu_domain.c | 4 ++++
|
|
|
fbe740 |
1 file changed, 4 insertions(+)
|
|
|
fbe740 |
|
|
|
fbe740 |
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
|
|
|
fbe740 |
index f037f0812e..ed35260712 100644
|
|
|
fbe740 |
--- a/src/qemu/qemu_domain.c
|
|
|
fbe740 |
+++ b/src/qemu/qemu_domain.c
|
|
|
fbe740 |
@@ -11598,6 +11598,10 @@ qemuDomainDetermineDiskChain(virQEMUDriverPtr driver,
|
|
|
fbe740 |
return -1;
|
|
|
fbe740 |
|
|
|
fbe740 |
for (n = src->backingStore; virStorageSourceIsBacking(n); n = n->backingStore) {
|
|
|
fbe740 |
+ /* convert detected ISO format to 'raw' as qemu would not understand it */
|
|
|
fbe740 |
+ if (n->format == VIR_STORAGE_FILE_ISO)
|
|
|
fbe740 |
+ n->format = VIR_STORAGE_FILE_RAW;
|
|
|
fbe740 |
+
|
|
|
fbe740 |
if (qemuDomainValidateStorageSource(n, priv->qemuCaps) < 0)
|
|
|
fbe740 |
return -1;
|
|
|
fbe740 |
|
|
|
fbe740 |
--
|
|
|
fbe740 |
2.25.1
|
|
|
fbe740 |
|