|
 |
edecca |
From c39dd7dec2fe7ab631de9ef02a1d654385810750 Mon Sep 17 00:00:00 2001
|
|
|
edecca |
Message-Id: <c39dd7dec2fe7ab631de9ef02a1d654385810750@dist-git>
|
|
|
edecca |
From: John Ferlan <jferlan@redhat.com>
|
|
|
edecca |
Date: Thu, 10 Jan 2019 12:49:10 +0100
|
|
|
edecca |
Subject: [PATCH] qemu: Remove duplicated qemuAgentCheckError
|
|
|
edecca |
MIME-Version: 1.0
|
|
|
edecca |
Content-Type: text/plain; charset=UTF-8
|
|
|
edecca |
Content-Transfer-Encoding: 8bit
|
|
|
edecca |
|
|
|
edecca |
Commit 5b3492fadb moved qemuAgentCheckError calls into
|
|
|
edecca |
qemuAgentCommand for various reasons; however, subsequent
|
|
|
edecca |
commit 0977b8aa0 adding a new command made call again
|
|
|
edecca |
So let's just remove the duplicitous call from
|
|
|
edecca |
qemuAgentGetInterfaces.
|
|
|
edecca |
|
|
|
edecca |
Signed-off-by: John Ferlan <jferlan@redhat.com>
|
|
|
edecca |
ACKed-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
edecca |
(cherry picked from commit 9ed175fbc2deecfdaeabca7bc77c7e7ae33a3377)
|
|
|
edecca |
Signed-off-by: Ján Tomko <jtomko@redhat.com>
|
|
|
edecca |
|
|
|
edecca |
7.7: https://bugzilla.redhat.com/show_bug.cgi?id=1663051
|
|
|
edecca |
8.0: https://bugzilla.redhat.com/show_bug.cgi?id=1665000
|
|
|
edecca |
|
|
|
edecca |
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
edecca |
---
|
|
|
edecca |
src/qemu/qemu_agent.c | 5 ++---
|
|
|
edecca |
1 file changed, 2 insertions(+), 3 deletions(-)
|
|
|
edecca |
|
|
|
edecca |
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
|
|
|
edecca |
index 10c6ef09fa..986e37b07d 100644
|
|
|
edecca |
--- a/src/qemu/qemu_agent.c
|
|
|
edecca |
+++ b/src/qemu/qemu_agent.c
|
|
|
edecca |
@@ -1987,10 +1987,9 @@ qemuAgentGetInterfaces(qemuAgentPtr mon,
|
|
|
edecca |
if (!(cmd = qemuAgentMakeCommand("guest-network-get-interfaces", NULL)))
|
|
|
edecca |
goto cleanup;
|
|
|
edecca |
|
|
|
edecca |
- if (qemuAgentCommand(mon, cmd, &reply, false, VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK) < 0 ||
|
|
|
edecca |
- qemuAgentCheckError(cmd, reply) < 0) {
|
|
|
edecca |
+ if (qemuAgentCommand(mon, cmd, &reply, false,
|
|
|
edecca |
+ VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK) < 0)
|
|
|
edecca |
goto cleanup;
|
|
|
edecca |
- }
|
|
|
edecca |
|
|
|
edecca |
if (!(ret_array = virJSONValueObjectGet(reply, "return"))) {
|
|
|
edecca |
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
edecca |
--
|
|
|
edecca |
2.20.1
|
|
|
edecca |
|