|
 |
99cbc7 |
From 055b060ce71a1e173606e015d219158c945f0295 Mon Sep 17 00:00:00 2001
|
|
|
99cbc7 |
Message-Id: <055b060ce71a1e173606e015d219158c945f0295@dist-git>
|
|
|
99cbc7 |
From: John Ferlan <jferlan@redhat.com>
|
|
|
99cbc7 |
Date: Fri, 13 Jul 2018 10:02:34 +0200
|
|
|
99cbc7 |
Subject: [PATCH] qemu: Fix ATTRIBUTE_NONNULL for qemuMonitorAddObject
|
|
|
99cbc7 |
|
|
|
99cbc7 |
Commit id fac0dacd was trying to make things more robust;
|
|
|
99cbc7 |
however, the ATTRIBUTE_NONNULL(1) would be for the @mon,
|
|
|
99cbc7 |
not the intended (2) and the @props argument as described
|
|
|
99cbc7 |
in the commit message.
|
|
|
99cbc7 |
|
|
|
99cbc7 |
Found by Coverity build.
|
|
|
99cbc7 |
|
|
|
99cbc7 |
Signed-off-by: John Ferlan <jferlan@redhat.com>
|
|
|
99cbc7 |
(cherry picked from commit 7406ab691ffe0fbe051f6ae57614737e193df6a5)
|
|
|
99cbc7 |
|
|
|
99cbc7 |
The broken commit described in the original commit message was
|
|
|
99cbc7 |
backported as 1d60f6832c8b14c9a
|
|
|
99cbc7 |
|
|
|
99cbc7 |
https: //bugzilla.redhat.com/show_bug.cgi?id=1598015
|
|
|
99cbc7 |
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
99cbc7 |
---
|
|
|
99cbc7 |
src/qemu/qemu_monitor.h | 2 +-
|
|
|
99cbc7 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
99cbc7 |
|
|
|
99cbc7 |
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
|
|
|
99cbc7 |
index e3eb14bf06..e6d235b5ba 100644
|
|
|
99cbc7 |
--- a/src/qemu/qemu_monitor.h
|
|
|
99cbc7 |
+++ b/src/qemu/qemu_monitor.h
|
|
|
99cbc7 |
@@ -824,7 +824,7 @@ int qemuMonitorCreateObjectProps(virJSONValuePtr *propsret,
|
|
|
99cbc7 |
int qemuMonitorAddObject(qemuMonitorPtr mon,
|
|
|
99cbc7 |
virJSONValuePtr *props,
|
|
|
99cbc7 |
char **alias)
|
|
|
99cbc7 |
- ATTRIBUTE_NONNULL(1);
|
|
|
99cbc7 |
+ ATTRIBUTE_NONNULL(2);
|
|
|
99cbc7 |
|
|
|
99cbc7 |
int qemuMonitorDelObject(qemuMonitorPtr mon,
|
|
|
99cbc7 |
const char *objalias);
|
|
|
99cbc7 |
--
|
|
|
99cbc7 |
2.18.0
|
|
|
99cbc7 |
|