render / rpms / libvirt

Forked from rpms/libvirt 9 months ago
Clone
0a7476
From cc4e45e8bcb2d141bbf2ddc14e0fef8c234662df Mon Sep 17 00:00:00 2001
0a7476
Message-Id: <cc4e45e8bcb2d141bbf2ddc14e0fef8c234662df@dist-git>
0a7476
From: Andrea Bolognani <abologna@redhat.com>
0a7476
Date: Fri, 5 Apr 2019 10:57:43 +0200
0a7476
Subject: [PATCH] qemu: Don't check for /dev/kvm presence
0a7476
0a7476
The file being present doesn't necessarily mean anything these
0a7476
days, as it's created independently of whether the kvm module
0a7476
has been loaded[1]; moreover, we're already gathering all the
0a7476
information we need through QMP, so poking the filesystem at
0a7476
all is entirely unnecessary.
0a7476
0a7476
[1] https://github.com/systemd/systemd/commit/d35d6249d5a7ed3228
0a7476
0a7476
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
0a7476
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
0a7476
(cherry picked from commit 2f8b91ee74ff617aba322d034119427cad977af9)
0a7476
0a7476
https://bugzilla.redhat.com/show_bug.cgi?id=1628469
0a7476
0a7476
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
0a7476
Message-Id: <20190405085744.8179-7-abologna@redhat.com>
0a7476
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
0a7476
---
0a7476
 src/qemu/qemu_capabilities.c | 5 ++---
0a7476
 1 file changed, 2 insertions(+), 3 deletions(-)
0a7476
0a7476
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
0a7476
index 6386f206b8..8819452ff6 100644
0a7476
--- a/src/qemu/qemu_capabilities.c
0a7476
+++ b/src/qemu/qemu_capabilities.c
0a7476
@@ -832,9 +832,8 @@ virQEMUCapsInitGuestFromBinary(virCapsPtr caps,
0a7476
     if (!binary)
0a7476
         return 0;
0a7476
 
0a7476
-    if (virFileExists("/dev/kvm") &&
0a7476
-        (virQEMUCapsGet(qemubinCaps, QEMU_CAPS_KVM) ||
0a7476
-         kvmbin))
0a7476
+    if (virQEMUCapsGet(qemubinCaps, QEMU_CAPS_KVM) ||
0a7476
+        kvmbin)
0a7476
         haskvm = true;
0a7476
 
0a7476
     if (virQEMUCapsGetMachineTypesCaps(qemubinCaps, &nmachines, &machines) < 0)
0a7476
-- 
0a7476
2.21.0
0a7476