|
 |
79b470 |
From b91bb231645300a29ab82994a003ba22835ee994 Mon Sep 17 00:00:00 2001
|
|
|
79b470 |
Message-Id: <b91bb231645300a29ab82994a003ba22835ee994@dist-git>
|
|
|
79b470 |
From: Jiri Denemark <jdenemar@redhat.com>
|
|
|
79b470 |
Date: Thu, 8 Oct 2020 18:01:26 +0200
|
|
|
79b470 |
Subject: [PATCH] cpu_map: Remove monitor feature from EPYC-Rome
|
|
|
79b470 |
MIME-Version: 1.0
|
|
|
79b470 |
Content-Type: text/plain; charset=UTF-8
|
|
|
79b470 |
Content-Transfer-Encoding: 8bit
|
|
|
79b470 |
|
|
|
79b470 |
The feature is filtered by KVM and never automatically enabled. So even
|
|
|
79b470 |
though QEMU definition of EPYC-Rome contains this feature, the guest
|
|
|
79b470 |
won't see it. Also domain capabilities will show it as disabled for KVM
|
|
|
79b470 |
domains. Thus the feature should not really be included in our
|
|
|
79b470 |
definition of EPYC-Rome.
|
|
|
79b470 |
|
|
|
79b470 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
79b470 |
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
|
|
|
79b470 |
(cherry picked from commit 3bf6f9fe22dfbd3c1dcc614b31f2f4fe8b71a2f2)
|
|
|
79b470 |
|
|
|
79b470 |
https://bugzilla.redhat.com/show_bug.cgi?id=1861506
|
|
|
79b470 |
|
|
|
79b470 |
Conflicts:
|
|
|
79b470 |
tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml
|
|
|
79b470 |
tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml
|
|
|
79b470 |
tests/cputestdata/x86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml
|
|
|
79b470 |
tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml
|
|
|
79b470 |
tests/domaincapsdata/qemu_5.1.0.x86_64.xml
|
|
|
79b470 |
tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml
|
|
|
79b470 |
tests/domaincapsdata/qemu_5.2.0.x86_64.xml
|
|
|
79b470 |
- not present downstream
|
|
|
79b470 |
|
|
|
79b470 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
79b470 |
Message-Id: <74b9257f49925312b025a99dd934a9613ca295d4.1602172344.git.jdenemar@redhat.com>
|
|
|
79b470 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
79b470 |
---
|
|
|
79b470 |
src/cpu_map/x86_EPYC-Rome.xml | 1 -
|
|
|
79b470 |
tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +
|
|
|
79b470 |
tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml | 1 +
|
|
|
79b470 |
tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml | 1 -
|
|
|
79b470 |
4 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
79b470 |
|
|
|
79b470 |
diff --git a/src/cpu_map/x86_EPYC-Rome.xml b/src/cpu_map/x86_EPYC-Rome.xml
|
|
|
79b470 |
index 99fc015fdd..e54d0a48d8 100644
|
|
|
79b470 |
--- a/src/cpu_map/x86_EPYC-Rome.xml
|
|
|
79b470 |
+++ b/src/cpu_map/x86_EPYC-Rome.xml
|
|
|
79b470 |
@@ -37,7 +37,6 @@
|
|
|
79b470 |
<feature name='misalignsse'/>
|
|
|
79b470 |
<feature name='mmx'/>
|
|
|
79b470 |
<feature name='mmxext'/>
|
|
|
79b470 |
- <feature name='monitor'/>
|
|
|
79b470 |
<feature name='movbe'/>
|
|
|
79b470 |
<feature name='msr'/>
|
|
|
79b470 |
<feature name='mtrr'/>
|
|
|
79b470 |
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
|
|
|
79b470 |
index cb2caab6f5..6d95b508b2 100644
|
|
|
79b470 |
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
|
|
|
79b470 |
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
|
|
|
79b470 |
@@ -2,6 +2,7 @@
|
|
|
79b470 |
<model fallback='forbid'>EPYC-Rome</model>
|
|
|
79b470 |
<vendor>AMD</vendor>
|
|
|
79b470 |
<feature policy='require' name='ht'/>
|
|
|
79b470 |
+ <feature policy='require' name='monitor'/>
|
|
|
79b470 |
<feature policy='require' name='osxsave'/>
|
|
|
79b470 |
<feature policy='require' name='cmt'/>
|
|
|
79b470 |
<feature policy='require' name='xsaves'/>
|
|
|
79b470 |
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
|
|
|
79b470 |
index b6784f9eba..65eaeabdd0 100644
|
|
|
79b470 |
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
|
|
|
79b470 |
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
|
|
|
79b470 |
@@ -3,6 +3,7 @@
|
|
|
79b470 |
<model>EPYC-Rome</model>
|
|
|
79b470 |
<vendor>AMD</vendor>
|
|
|
79b470 |
<feature name='ht'/>
|
|
|
79b470 |
+ <feature name='monitor'/>
|
|
|
79b470 |
<feature name='osxsave'/>
|
|
|
79b470 |
<feature name='cmt'/>
|
|
|
79b470 |
<feature name='xsaves'/>
|
|
|
79b470 |
diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
|
|
|
79b470 |
index 86466c0547..febfdfcf2b 100644
|
|
|
79b470 |
--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
|
|
|
79b470 |
+++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-json.xml
|
|
|
79b470 |
@@ -17,5 +17,4 @@
|
|
|
79b470 |
<feature policy='require' name='skip-l1dfl-vmentry'/>
|
|
|
79b470 |
<feature policy='require' name='mds-no'/>
|
|
|
79b470 |
<feature policy='require' name='pschange-mc-no'/>
|
|
|
79b470 |
- <feature policy='disable' name='monitor'/>
|
|
|
79b470 |
</cpu>
|
|
|
79b470 |
--
|
|
|
79b470 |
2.29.2
|
|
|
79b470 |
|