render / rpms / libvirt

Forked from rpms/libvirt 10 months ago
Clone
edecca
From 195908ad66fc52643d94eca0f45e5740f25e3e78 Mon Sep 17 00:00:00 2001
edecca
Message-Id: <195908ad66fc52643d94eca0f45e5740f25e3e78@dist-git>
edecca
From: Laine Stump <laine@laine.org>
edecca
Date: Fri, 1 Feb 2019 20:29:26 -0500
edecca
Subject: [PATCH] Revert "RHEL: network: regain guest network connectivity
edecca
 after firewalld switch to nftables"
edecca
MIME-Version: 1.0
edecca
Content-Type: text/plain; charset=UTF-8
edecca
Content-Transfer-Encoding: 8bit
edecca
edecca
This reverts commit 54e270d7fb68b41002654374d395e4f260a24add.
edecca
edecca
This patch appeared in libvirt-4.5.0-11.el8 (RHEL git commit id
edecca
2fb53957). It was a downstream-only temporary fix to the networking
edecca
issues resulting from firewalld's switch to using nftables. Now that
edecca
there is a permanent fix upstream we can revert this patch and use the
edecca
upstream patches instead.
edecca
edecca
https://bugzilla.redhat.com/1650320
edecca
edecca
Signed-off-by: Laine Stump <laine@laine.org>
edecca
Reviewed-by: Ján Tomko <jtomko@redhat.com>
edecca
---
edecca
 libvirt.spec.in             | 14 --------------
edecca
 src/network/Makefile.inc.am | 10 +---------
edecca
 src/network/libvirt.zone    | 15 ---------------
edecca
 3 files changed, 1 insertion(+), 38 deletions(-)
edecca
 delete mode 100644 src/network/libvirt.zone
edecca
edecca
diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am
edecca
index 20d899e699..508c8c0422 100644
edecca
--- a/src/network/Makefile.inc.am
edecca
+++ b/src/network/Makefile.inc.am
edecca
@@ -87,11 +87,6 @@ install-data-network:
edecca
 	( cd $(DESTDIR)$(confdir)/qemu/networks/autostart && \
edecca
 	  rm -f default.xml && \
edecca
 	  $(LN_S) ../default.xml default.xml )
edecca
-if HAVE_FIREWALLD
edecca
-	$(MKDIR_P) "$(DESTDIR)$(prefix)/lib/firewalld/zones"
edecca
-	$(INSTALL_DATA) $(srcdir)/network/libvirt.zone \
edecca
-	  $(DESTDIR)$(prefix)/lib/firewalld/zones/libvirt.xml
edecca
-endif HAVE_FIREWALLD
edecca
 
edecca
 uninstall-data-network:
edecca
 	rm -f $(DESTDIR)$(confdir)/qemu/networks/autostart/default.xml
edecca
@@ -100,13 +95,10 @@ uninstall-data-network:
edecca
 	rmdir "$(DESTDIR)$(confdir)/qemu/networks" || :
edecca
 	rmdir "$(DESTDIR)$(localstatedir)/lib/libvirt/network" ||:
edecca
 	rmdir "$(DESTDIR)$(localstatedir)/run/libvirt/network" ||:
edecca
-if HAVE_FIREWALLD
edecca
-	rm -f  $(DESTDIR)$(prefix)/lib/firewalld/zones/libvirt.xml
edecca
-endif HAVE_FIREWALLD
edecca
 
edecca
 endif WITH_NETWORK
edecca
 
edecca
-EXTRA_DIST += network/default.xml network/libvirt.zone
edecca
+EXTRA_DIST += network/default.xml
edecca
 
edecca
 .PHONY: \
edecca
 	install-data-network \
edecca
diff --git a/src/network/libvirt.zone b/src/network/libvirt.zone
edecca
deleted file mode 100644
edecca
index 355a70b4da..0000000000
edecca
--- a/src/network/libvirt.zone
edecca
+++ /dev/null
edecca
@@ -1,15 +0,0 @@
edecca
-
edecca
-<zone target="ACCEPT">
edecca
-  <short>libvirt</short>
edecca
-  <description>All network connections are accepted. This also permits packets to/from interfaces in the zone to be forwarded. This zone is intended to be used only by libvirt virtual networks.</description>
edecca
-  <interface name="virbr0"/>
edecca
-  <interface name="virbr1"/>
edecca
-  <interface name="virbr2"/>
edecca
-  <interface name="virbr3"/>
edecca
-  <interface name="virbr4"/>
edecca
-  <interface name="virbr5"/>
edecca
-  <interface name="virbr6"/>
edecca
-  <interface name="virbr7"/>
edecca
-  <interface name="virbr8"/>
edecca
-  <interface name="virbr9"/>
edecca
-</zone>
edecca
-- 
edecca
2.20.1
edecca