render / rpms / libvirt

Forked from rpms/libvirt 11 months ago
Clone
27ca06
From f38c8185f97720ecae7ef2291fbaa5d6b0209e17 Mon Sep 17 00:00:00 2001
27ca06
Message-Id: <f38c8185f97720ecae7ef2291fbaa5d6b0209e17.1373575119.git.crobinso@redhat.com>
27ca06
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
27ca06
Date: Tue, 2 Jul 2013 15:17:09 +0200
27ca06
Subject: [PATCH] Fix crash when multiple event callbacks were registered
27ca06
27ca06
CVE-2013-2230
27ca06
27ca06
Don't overwrite the callback ID returned by
27ca06
virDomainEventStateRegisterID in ret by 0.
27ca06
27ca06
Introduced by abf75aea.
27ca06
---
27ca06
 src/qemu/qemu_driver.c | 4 +---
27ca06
 1 file changed, 1 insertion(+), 3 deletions(-)
27ca06
27ca06
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
27ca06
index 571d1f8..b0180c9 100644
27ca06
--- a/src/qemu/qemu_driver.c
27ca06
+++ b/src/qemu/qemu_driver.c
27ca06
@@ -10043,9 +10043,7 @@ qemuConnectDomainEventRegisterAny(virConnectPtr conn,
27ca06
                                       driver->domainEventState,
27ca06
                                       dom, eventID,
27ca06
                                       callback, opaque, freecb, &ret) < 0)
27ca06
-        goto cleanup;
27ca06
-
27ca06
-    ret = 0;
27ca06
+        ret = -1;
27ca06
 
27ca06
 cleanup:
27ca06
     return ret;
27ca06
-- 
27ca06
1.8.3.1
27ca06