|
 |
b35c50 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
b35c50 |
From: Hans de Goede <hdegoede@redhat.com>
|
|
|
b35c50 |
Date: Fri, 28 Jan 2022 12:43:49 +0100
|
|
|
b35c50 |
Subject: [PATCH] EFI: console: Do not set cursor until the first text output
|
|
|
b35c50 |
|
|
|
b35c50 |
To allow flickerfree boot the EFI console code does not call
|
|
|
b35c50 |
grub_efi_set_text_mode (1) until some text is actually output.
|
|
|
b35c50 |
|
|
|
b35c50 |
Depending on if the output text is because of an error loading
|
|
|
b35c50 |
e.g. the .cfg file; or because of showing the menu the cursor needs
|
|
|
b35c50 |
to be on or off when the first text is shown.
|
|
|
b35c50 |
|
|
|
b35c50 |
So far the cursor was hardcoded to being on, but this is causing
|
|
|
b35c50 |
drawing artifacts + slow drawing of the menu as reported here:
|
|
|
b35c50 |
https://bugzilla.redhat.com/show_bug.cgi?id=1946969
|
|
|
b35c50 |
|
|
|
b35c50 |
Handle the cursorstate in the same way as the colorstate to fix this,
|
|
|
b35c50 |
when no text has been output yet, just cache the cursorstate and
|
|
|
b35c50 |
then use the last set value when the first text is output.
|
|
|
b35c50 |
|
|
|
b35c50 |
Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actually need it")
|
|
|
b35c50 |
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
b35c50 |
---
|
|
|
b35c50 |
grub-core/term/efi/console.c | 19 ++++++++++++++++---
|
|
|
b35c50 |
1 file changed, 16 insertions(+), 3 deletions(-)
|
|
|
b35c50 |
|
|
|
b35c50 |
diff --git a/grub-core/term/efi/console.c b/grub-core/term/efi/console.c
|
|
|
b35c50 |
index c44b2ac318..a3622e4fe5 100644
|
|
|
b35c50 |
--- a/grub-core/term/efi/console.c
|
|
|
b35c50 |
+++ b/grub-core/term/efi/console.c
|
|
|
b35c50 |
@@ -31,7 +31,15 @@ typedef enum {
|
|
|
b35c50 |
}
|
|
|
b35c50 |
grub_text_mode;
|
|
|
b35c50 |
|
|
|
b35c50 |
+typedef enum {
|
|
|
b35c50 |
+ GRUB_CURSOR_MODE_UNDEFINED = -1,
|
|
|
b35c50 |
+ GRUB_CURSOR_MODE_OFF = 0,
|
|
|
b35c50 |
+ GRUB_CURSUR_MODE_ON
|
|
|
b35c50 |
+}
|
|
|
b35c50 |
+grub_cursor_mode;
|
|
|
b35c50 |
+
|
|
|
b35c50 |
static grub_text_mode text_mode = GRUB_TEXT_MODE_UNDEFINED;
|
|
|
b35c50 |
+static grub_cursor_mode cursor_mode = GRUB_CURSOR_MODE_UNDEFINED;
|
|
|
b35c50 |
static grub_term_color_state text_colorstate = GRUB_TERM_COLOR_UNDEFINED;
|
|
|
b35c50 |
|
|
|
b35c50 |
static grub_uint32_t
|
|
|
b35c50 |
@@ -119,8 +127,12 @@ grub_console_setcursor (struct grub_term_output *term __attribute__ ((unused)),
|
|
|
b35c50 |
{
|
|
|
b35c50 |
grub_efi_simple_text_output_interface_t *o;
|
|
|
b35c50 |
|
|
|
b35c50 |
- if (grub_efi_is_finished)
|
|
|
b35c50 |
- return;
|
|
|
b35c50 |
+ if (grub_efi_is_finished || text_mode != GRUB_TEXT_MODE_AVAILABLE)
|
|
|
b35c50 |
+ {
|
|
|
b35c50 |
+ /* Cache cursor changes before the first text-output */
|
|
|
b35c50 |
+ cursor_mode = on;
|
|
|
b35c50 |
+ return;
|
|
|
b35c50 |
+ }
|
|
|
b35c50 |
|
|
|
b35c50 |
o = grub_efi_system_table->con_out;
|
|
|
b35c50 |
efi_call_2 (o->enable_cursor, o, on);
|
|
|
b35c50 |
@@ -143,7 +155,8 @@ grub_prepare_for_text_output (struct grub_term_output *term)
|
|
|
b35c50 |
return GRUB_ERR_BAD_DEVICE;
|
|
|
b35c50 |
}
|
|
|
b35c50 |
|
|
|
b35c50 |
- grub_console_setcursor (term, 1);
|
|
|
b35c50 |
+ if (cursor_mode != GRUB_CURSOR_MODE_UNDEFINED)
|
|
|
b35c50 |
+ grub_console_setcursor (term, cursor_mode);
|
|
|
b35c50 |
if (text_colorstate != GRUB_TERM_COLOR_UNDEFINED)
|
|
|
b35c50 |
grub_console_setcolorstate (term, text_colorstate);
|
|
|
b35c50 |
text_mode = GRUB_TEXT_MODE_AVAILABLE;
|