nalika / rpms / grub2

Forked from rpms/grub2 2 years ago
Clone

Blame SOURCES/0181-tcp-ack-when-we-get-an-OOO-lost-packet.patch

f725e3
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
f725e3
From: Josef Bacik <jbacik@fb.com>
f725e3
Date: Wed, 12 Aug 2015 08:16:22 -0700
f725e3
Subject: [PATCH] tcp: ack when we get an OOO/lost packet
f725e3
f725e3
While adding tcp window scaling support I was finding that I'd get some packet
f725e3
loss or reordering when transferring from large distances and grub would just
f725e3
timeout.  This is because we weren't ack'ing when we got our OOO packet, so the
f725e3
sender didn't know it needed to retransmit anything, so eventually it would fill
f725e3
the window and stop transmitting, and we'd time out.  Fix this by ACK'ing when
f725e3
we don't find our next sequence numbered packet.  With this fix I no longer time
f725e3
out.  Thanks,
f725e3
f725e3
Signed-off-by: Josef Bacik <jbacik@fb.com>
f725e3
---
f725e3
 grub-core/net/tcp.c | 5 ++++-
f725e3
 1 file changed, 4 insertions(+), 1 deletion(-)
f725e3
f725e3
diff --git a/grub-core/net/tcp.c b/grub-core/net/tcp.c
f725e3
index 2077f5519b2..fa29a2afc6c 100644
f725e3
--- a/grub-core/net/tcp.c
f725e3
+++ b/grub-core/net/tcp.c
f725e3
@@ -882,7 +882,10 @@ grub_net_recv_tcp_packet (struct grub_net_buff *nb,
f725e3
 	  grub_priority_queue_pop (sock->pq);
f725e3
 	}
f725e3
       if (grub_be_to_cpu32 (tcph->seqnr) != sock->their_cur_seq)
f725e3
-	return GRUB_ERR_NONE;
f725e3
+	{
f725e3
+	  ack (sock);
f725e3
+	  return GRUB_ERR_NONE;
f725e3
+	}
f725e3
       while (1)
f725e3
 	{
f725e3
 	  nb_top_p = grub_priority_queue_top (sock->pq);