From 14b393f9d9b7caffcd48557c6bd4eb63de4942ad Mon Sep 17 00:00:00 2001

From: Lennart Poettering <lennart@poettering.net>

Date: Mon, 16 Jun 2014 17:01:26 +0200

Subject: [PATCH] unit-name: fix detection of unit templates/instances

We need to check for the last dot, not the first one in a unit name, for

the suffix. Correct that.

(cherry-picked from 6ef9eeed61a291cc42b7d911f5cf5a4deca742a3)

Resolves: #1147524

---

 src/shared/unit-name.c | 16 ++++++++++++----

 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/shared/unit-name.c b/src/shared/unit-name.c

index bc8094d..577f7e7 100644

--- a/src/shared/unit-name.c

+++ b/src/shared/unit-name.c

@@ -334,7 +334,7 @@ char *unit_name_path_unescape(const char *f) {

 }

 bool unit_name_is_template(const char *n) {

-        const char *p;

+        const char *p, *e;

         assert(n);

@@ -342,11 +342,15 @@ bool unit_name_is_template(const char *n) {

         if (!p)

                 return false;

-        return p[1] == '.';

+        e = strrchr(p+1, '.');

+        if (!e)

+                return false;

+

+        return e == p + 1;

 }

 bool unit_name_is_instance(const char *n) {

-        const char *p;

+        const char *p, *e;

         assert(n);

@@ -354,7 +358,11 @@ bool unit_name_is_instance(const char *n) {

         if (!p)

                 return false;

-        return p[1] != '.';

+        e = strrchr(p+1, '.');

+        if (!e)

+                return false;

+

+        return e > p + 1;

 }

 char *unit_name_replace_instance(const char *f, const char *i) {