|
 |
1abbee |
From 2a9dd5375b4f35a101d6ef3deb035d901d7a2392 Mon Sep 17 00:00:00 2001
|
|
|
1abbee |
From: Lennart Poettering <lennart@poettering.net>
|
|
|
1abbee |
Date: Fri, 24 Jul 2015 02:18:13 +0200
|
|
|
1abbee |
Subject: [PATCH] journal: uppercase first character in verify error messages
|
|
|
1abbee |
|
|
|
1abbee |
In the english language the first character of a sentence is supposed to
|
|
|
1abbee |
be uppercase. Let's make sure this also applies to the journal
|
|
|
1abbee |
verification error messages.
|
|
|
1abbee |
|
|
|
1abbee |
Cherry-picked from: e80acc51aeaf2d74cb4d6cecbcb6e18f74c22c05
|
|
|
1abbee |
Related: #1350232
|
|
|
1abbee |
---
|
|
|
1abbee |
src/journal/journal-verify.c | 162 ++++++++++++++++++++-----------------------
|
|
|
1abbee |
1 file changed, 75 insertions(+), 87 deletions(-)
|
|
|
1abbee |
|
|
|
1abbee |
diff --git a/src/journal/journal-verify.c b/src/journal/journal-verify.c
|
|
|
181b3f |
index 77fb4090d..8a66ac7f0 100644
|
|
|
1abbee |
--- a/src/journal/journal-verify.c
|
|
|
1abbee |
+++ b/src/journal/journal-verify.c
|
|
|
1abbee |
@@ -135,15 +135,15 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
int compression, r;
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(o->data.entry_offset) == 0)
|
|
|
1abbee |
- warning(offset, "unused data (entry_offset==0)");
|
|
|
1abbee |
+ warning(offset, "Unused data (entry_offset==0)");
|
|
|
1abbee |
|
|
|
1abbee |
if ((le64toh(o->data.entry_offset) == 0) ^ (le64toh(o->data.n_entries) == 0)) {
|
|
|
1abbee |
- error(offset, "bad n_entries: %"PRIu64, o->data.n_entries);
|
|
|
1abbee |
+ error(offset, "Bad n_entries: %"PRIu64, o->data.n_entries);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(o->object.size) - offsetof(DataObject, payload) <= 0) {
|
|
|
1abbee |
- error(offset, "bad object size (<= %zu): %"PRIu64,
|
|
|
1abbee |
+ error(offset, "Bad object size (<= %zu): %"PRIu64,
|
|
|
1abbee |
offsetof(DataObject, payload),
|
|
|
1abbee |
le64toh(o->object.size));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
@@ -171,7 +171,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
h2 = hash64(o->data.payload, le64toh(o->object.size) - offsetof(Object, data.payload));
|
|
|
1abbee |
|
|
|
1abbee |
if (h1 != h2) {
|
|
|
1abbee |
- error(offset, "invalid hash (%08"PRIx64" vs. %08"PRIx64, h1, h2);
|
|
|
1abbee |
+ error(offset, "Invalid hash (%08"PRIx64" vs. %08"PRIx64, h1, h2);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -179,7 +179,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
!VALID64(o->data.next_field_offset) ||
|
|
|
1abbee |
!VALID64(o->data.entry_offset) ||
|
|
|
1abbee |
!VALID64(o->data.entry_array_offset)) {
|
|
|
1abbee |
- error(offset, "invalid offset (next_hash_offset="OFSfmt", next_field_offset="OFSfmt", entry_offset="OFSfmt", entry_array_offset="OFSfmt,
|
|
|
1abbee |
+ error(offset, "Invalid offset (next_hash_offset="OFSfmt", next_field_offset="OFSfmt", entry_offset="OFSfmt", entry_array_offset="OFSfmt,
|
|
|
1abbee |
o->data.next_hash_offset,
|
|
|
1abbee |
o->data.next_field_offset,
|
|
|
1abbee |
o->data.entry_offset,
|
|
|
1abbee |
@@ -193,7 +193,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
case OBJECT_FIELD:
|
|
|
1abbee |
if (le64toh(o->object.size) - offsetof(FieldObject, payload) <= 0) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "bad field size (<= %zu): %"PRIu64,
|
|
|
1abbee |
+ "Bad field size (<= %zu): %"PRIu64,
|
|
|
1abbee |
offsetof(FieldObject, payload),
|
|
|
1abbee |
le64toh(o->object.size));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
@@ -202,7 +202,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if (!VALID64(o->field.next_hash_offset) ||
|
|
|
1abbee |
!VALID64(o->field.head_data_offset)) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid offset (next_hash_offset="OFSfmt", head_data_offset="OFSfmt,
|
|
|
1abbee |
+ "Invalid offset (next_hash_offset="OFSfmt", head_data_offset="OFSfmt,
|
|
|
1abbee |
o->field.next_hash_offset,
|
|
|
1abbee |
o->field.head_data_offset);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
@@ -212,7 +212,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
case OBJECT_ENTRY:
|
|
|
1abbee |
if ((le64toh(o->object.size) - offsetof(EntryObject, items)) % sizeof(EntryItem) != 0) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "bad entry size (<= %zu): %"PRIu64,
|
|
|
1abbee |
+ "Bad entry size (<= %zu): %"PRIu64,
|
|
|
1abbee |
offsetof(EntryObject, items),
|
|
|
1abbee |
le64toh(o->object.size));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
@@ -220,28 +220,28 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
|
|
|
1abbee |
if ((le64toh(o->object.size) - offsetof(EntryObject, items)) / sizeof(EntryItem) <= 0) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid number items in entry: %"PRIu64,
|
|
|
1abbee |
+ "Invalid number items in entry: %"PRIu64,
|
|
|
1abbee |
(le64toh(o->object.size) - offsetof(EntryObject, items)) / sizeof(EntryItem));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(o->entry.seqnum) <= 0) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid entry seqnum: %"PRIx64,
|
|
|
1abbee |
+ "Invalid entry seqnum: %"PRIx64,
|
|
|
1abbee |
le64toh(o->entry.seqnum));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!VALID_REALTIME(le64toh(o->entry.realtime))) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid entry realtime timestamp: %"PRIu64,
|
|
|
1abbee |
+ "Invalid entry realtime timestamp: %"PRIu64,
|
|
|
1abbee |
le64toh(o->entry.realtime));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!VALID_MONOTONIC(le64toh(o->entry.monotonic))) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid entry monotonic timestamp: %"PRIu64,
|
|
|
1abbee |
+ "Invalid entry monotonic timestamp: %"PRIu64,
|
|
|
1abbee |
le64toh(o->entry.monotonic));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -250,7 +250,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if (o->entry.items[i].object_offset == 0 ||
|
|
|
1abbee |
!VALID64(o->entry.items[i].object_offset)) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid entry item (%"PRIu64"/%"PRIu64" offset: "OFSfmt,
|
|
|
1abbee |
+ "Invalid entry item (%"PRIu64"/%"PRIu64" offset: "OFSfmt,
|
|
|
1abbee |
i, journal_file_entry_n_items(o),
|
|
|
1abbee |
o->entry.items[i].object_offset);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
@@ -264,7 +264,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if ((le64toh(o->object.size) - offsetof(HashTableObject, items)) % sizeof(HashItem) != 0 ||
|
|
|
1abbee |
(le64toh(o->object.size) - offsetof(HashTableObject, items)) / sizeof(HashItem) <= 0) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid %s hash table size: %"PRIu64,
|
|
|
1abbee |
+ "Invalid %s hash table size: %"PRIu64,
|
|
|
1abbee |
o->object.type == OBJECT_DATA_HASH_TABLE ? "data" : "field",
|
|
|
1abbee |
le64toh(o->object.size));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
@@ -274,7 +274,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if (o->hash_table.items[i].head_hash_offset != 0 &&
|
|
|
1abbee |
!VALID64(le64toh(o->hash_table.items[i].head_hash_offset))) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid %s hash table item (%"PRIu64"/%"PRIu64") head_hash_offset: "OFSfmt,
|
|
|
1abbee |
+ "Invalid %s hash table item (%"PRIu64"/%"PRIu64") head_hash_offset: "OFSfmt,
|
|
|
1abbee |
o->object.type == OBJECT_DATA_HASH_TABLE ? "data" : "field",
|
|
|
1abbee |
i, journal_file_hash_table_n_items(o),
|
|
|
1abbee |
le64toh(o->hash_table.items[i].head_hash_offset));
|
|
|
1abbee |
@@ -283,7 +283,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if (o->hash_table.items[i].tail_hash_offset != 0 &&
|
|
|
1abbee |
!VALID64(le64toh(o->hash_table.items[i].tail_hash_offset))) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid %s hash table item (%"PRIu64"/%"PRIu64") tail_hash_offset: "OFSfmt,
|
|
|
1abbee |
+ "Invalid %s hash table item (%"PRIu64"/%"PRIu64") tail_hash_offset: "OFSfmt,
|
|
|
1abbee |
o->object.type == OBJECT_DATA_HASH_TABLE ? "data" : "field",
|
|
|
1abbee |
i, journal_file_hash_table_n_items(o),
|
|
|
1abbee |
le64toh(o->hash_table.items[i].tail_hash_offset));
|
|
|
1abbee |
@@ -293,7 +293,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if ((o->hash_table.items[i].head_hash_offset != 0) !=
|
|
|
1abbee |
(o->hash_table.items[i].tail_hash_offset != 0)) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid %s hash table item (%"PRIu64"/%"PRIu64"): head_hash_offset="OFSfmt" tail_hash_offset="OFSfmt,
|
|
|
1abbee |
+ "Invalid %s hash table item (%"PRIu64"/%"PRIu64"): head_hash_offset="OFSfmt" tail_hash_offset="OFSfmt,
|
|
|
1abbee |
o->object.type == OBJECT_DATA_HASH_TABLE ? "data" : "field",
|
|
|
1abbee |
i, journal_file_hash_table_n_items(o),
|
|
|
1abbee |
le64toh(o->hash_table.items[i].head_hash_offset),
|
|
|
1abbee |
@@ -308,14 +308,14 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if ((le64toh(o->object.size) - offsetof(EntryArrayObject, items)) % sizeof(le64_t) != 0 ||
|
|
|
1abbee |
(le64toh(o->object.size) - offsetof(EntryArrayObject, items)) / sizeof(le64_t) <= 0) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid object entry array size: %"PRIu64,
|
|
|
1abbee |
+ "Invalid object entry array size: %"PRIu64,
|
|
|
1abbee |
le64toh(o->object.size));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!VALID64(o->entry_array.next_entry_array_offset)) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid object entry array next_entry_array_offset: "OFSfmt,
|
|
|
1abbee |
+ "Invalid object entry array next_entry_array_offset: "OFSfmt,
|
|
|
1abbee |
o->entry_array.next_entry_array_offset);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -324,7 +324,7 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
if (le64toh(o->entry_array.items[i]) != 0 &&
|
|
|
1abbee |
!VALID64(le64toh(o->entry_array.items[i]))) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid object entry array item (%"PRIu64"/%"PRIu64"): "OFSfmt,
|
|
|
1abbee |
+ "Invalid object entry array item (%"PRIu64"/%"PRIu64"): "OFSfmt,
|
|
|
1abbee |
i, journal_file_entry_array_n_items(o),
|
|
|
1abbee |
le64toh(o->entry_array.items[i]));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
@@ -335,14 +335,14 @@ static int journal_file_object_verify(JournalFile *f, uint64_t offset, Object *o
|
|
|
1abbee |
case OBJECT_TAG:
|
|
|
1abbee |
if (le64toh(o->object.size) != sizeof(TagObject)) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid object tag size: %"PRIu64,
|
|
|
1abbee |
+ "Invalid object tag size: %"PRIu64,
|
|
|
1abbee |
le64toh(o->object.size));
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!VALID_EPOCH(o->tag.epoch)) {
|
|
|
1abbee |
error(offset,
|
|
|
1abbee |
- "invalid object tag epoch: %"PRIu64,
|
|
|
1abbee |
+ "Invalid object tag epoch: %"PRIu64,
|
|
|
1abbee |
o->tag.epoch);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -415,8 +415,7 @@ static int entry_points_to_data(
|
|
|
1abbee |
assert(entry_fd >= 0);
|
|
|
1abbee |
|
|
|
1abbee |
if (!contains_uint64(f->mmap, entry_fd, n_entries, entry_p)) {
|
|
|
1abbee |
- error(data_p,
|
|
|
1abbee |
- "data object references invalid entry at "OFSfmt, entry_p);
|
|
|
1abbee |
+ error(data_p, "Data object references invalid entry at "OFSfmt, entry_p);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -432,8 +431,7 @@ static int entry_points_to_data(
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!found) {
|
|
|
1abbee |
- error(entry_p,
|
|
|
1abbee |
- "data object at "OFSfmt" not referenced by linked entry", data_p);
|
|
|
1abbee |
+ error(entry_p, "Data object at "OFSfmt" not referenced by linked entry", data_p);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -476,7 +474,7 @@ static int entry_points_to_data(
|
|
|
1abbee |
x = z;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
- error(entry_p, "entry object doesn't exist in main entry array");
|
|
|
1abbee |
+ error(entry_p, "Entry object doesn't exist in main entry array");
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -506,9 +504,7 @@ static int verify_data(
|
|
|
1abbee |
|
|
|
1abbee |
/* Entry array means at least two objects */
|
|
|
1abbee |
if (a && n < 2) {
|
|
|
1abbee |
- error(p,
|
|
|
1abbee |
- "entry array present (entry_array_offset="OFSfmt", but n_entries=%"PRIu64")",
|
|
|
1abbee |
- a, n);
|
|
|
1abbee |
+ error(p, "Entry array present (entry_array_offset="OFSfmt", but n_entries=%"PRIu64")", a, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -528,12 +524,12 @@ static int verify_data(
|
|
|
1abbee |
uint64_t next, m, j;
|
|
|
1abbee |
|
|
|
1abbee |
if (a == 0) {
|
|
|
1abbee |
- error(p, "array chain too short");
|
|
|
1abbee |
+ error(p, "Array chain too short");
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!contains_uint64(f->mmap, entry_array_fd, n_entry_arrays, a)) {
|
|
|
1abbee |
- error(p, "invalid array offset "OFSfmt, a);
|
|
|
1abbee |
+ error(p, "Invalid array offset "OFSfmt, a);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -543,8 +539,7 @@ static int verify_data(
|
|
|
1abbee |
|
|
|
1abbee |
next = le64toh(o->entry_array.next_entry_array_offset);
|
|
|
1abbee |
if (next != 0 && next <= a) {
|
|
|
1abbee |
- error(p, "array chain has cycle (jumps back from "OFSfmt" to "OFSfmt")",
|
|
|
1abbee |
- a, next);
|
|
|
1abbee |
+ error(p, "Array chain has cycle (jumps back from "OFSfmt" to "OFSfmt")", a, next);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -553,7 +548,7 @@ static int verify_data(
|
|
|
1abbee |
|
|
|
1abbee |
q = le64toh(o->entry_array.items[j]);
|
|
|
1abbee |
if (q <= last) {
|
|
|
1abbee |
- error(p, "data object's entry array not sorted");
|
|
|
1abbee |
+ error(p, "Data object's entry array not sorted");
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
last = q;
|
|
|
1abbee |
@@ -611,8 +606,7 @@ static int verify_hash_table(
|
|
|
1abbee |
uint64_t next;
|
|
|
1abbee |
|
|
|
1abbee |
if (!contains_uint64(f->mmap, data_fd, n_data, p)) {
|
|
|
1abbee |
- error(p, "invalid data object at hash entry %"PRIu64" of %"PRIu64,
|
|
|
1abbee |
- i, n);
|
|
|
1abbee |
+ error(p, "Invalid data object at hash entry %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -622,14 +616,12 @@ static int verify_hash_table(
|
|
|
1abbee |
|
|
|
1abbee |
next = le64toh(o->data.next_hash_offset);
|
|
|
1abbee |
if (next != 0 && next <= p) {
|
|
|
1abbee |
- error(p, "hash chain has a cycle in hash entry %"PRIu64" of %"PRIu64,
|
|
|
1abbee |
- i, n);
|
|
|
1abbee |
+ error(p, "Hash chain has a cycle in hash entry %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(o->data.hash) % n != i) {
|
|
|
1abbee |
- error(p, "hash value mismatch in hash entry %"PRIu64" of %"PRIu64,
|
|
|
1abbee |
- i, n);
|
|
|
1abbee |
+ error(p, "Hash value mismatch in hash entry %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -642,7 +634,7 @@ static int verify_hash_table(
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (last != le64toh(f->data_hash_table[i].tail_hash_offset)) {
|
|
|
1abbee |
- error(p, "tail hash pointer mismatch in hash table");
|
|
|
1abbee |
+ error(p, "Tail hash pointer mismatch in hash table");
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -703,16 +695,16 @@ static int verify_entry(
|
|
|
1abbee |
h = le64toh(o->entry.items[i].hash);
|
|
|
1abbee |
|
|
|
1abbee |
if (!contains_uint64(f->mmap, data_fd, n_data, q)) {
|
|
|
1abbee |
- error(p, "invalid data object of entry");
|
|
|
1abbee |
- return -EBADMSG;
|
|
|
1abbee |
- }
|
|
|
1abbee |
+ error(p, "Invalid data object of entry");
|
|
|
1abbee |
+ return -EBADMSG;
|
|
|
1abbee |
+ }
|
|
|
1abbee |
|
|
|
1abbee |
r = journal_file_move_to_object(f, OBJECT_DATA, q, &u);
|
|
|
1abbee |
if (r < 0)
|
|
|
1abbee |
return r;
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(u->data.hash) != h) {
|
|
|
1abbee |
- error(p, "hash mismatch for data object of entry");
|
|
|
1abbee |
+ error(p, "Hash mismatch for data object of entry");
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -720,7 +712,7 @@ static int verify_entry(
|
|
|
1abbee |
if (r < 0)
|
|
|
1abbee |
return r;
|
|
|
1abbee |
if (r == 0) {
|
|
|
1abbee |
- error(p, "data object missing from hash table");
|
|
|
1abbee |
+ error(p, "Data object missing from hash table");
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -755,12 +747,12 @@ static int verify_entry_array(
|
|
|
1abbee |
draw_progress(0x8000 + scale_progress(0x3FFF, i, n), last_usec);
|
|
|
1abbee |
|
|
|
1abbee |
if (a == 0) {
|
|
|
1abbee |
- error(a, "array chain too short at %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
+ error(a, "Array chain too short at %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!contains_uint64(f->mmap, entry_array_fd, n_entry_arrays, a)) {
|
|
|
1abbee |
- error(a, "invalid array %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
+ error(a, "Invalid array %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -770,9 +762,7 @@ static int verify_entry_array(
|
|
|
1abbee |
|
|
|
1abbee |
next = le64toh(o->entry_array.next_entry_array_offset);
|
|
|
1abbee |
if (next != 0 && next <= a) {
|
|
|
1abbee |
- error(a,
|
|
|
1abbee |
- "array chain has cycle at %"PRIu64" of %"PRIu64" (jumps back from to "OFSfmt")",
|
|
|
1abbee |
- i, n, next);
|
|
|
1abbee |
+ error(a, "Array chain has cycle at %"PRIu64" of %"PRIu64" (jumps back from to "OFSfmt")", i, n, next);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -782,15 +772,13 @@ static int verify_entry_array(
|
|
|
1abbee |
|
|
|
1abbee |
p = le64toh(o->entry_array.items[j]);
|
|
|
1abbee |
if (p <= last) {
|
|
|
1abbee |
- error(a, "entry array not sorted at %"PRIu64" of %"PRIu64,
|
|
|
1abbee |
- i, n);
|
|
|
1abbee |
+ error(a, "Entry array not sorted at %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
last = p;
|
|
|
1abbee |
|
|
|
1abbee |
if (!contains_uint64(f->mmap, entry_fd, n_entries, p)) {
|
|
|
1abbee |
- error(a, "invalid array entry at %"PRIu64" of %"PRIu64,
|
|
|
1abbee |
- i, n);
|
|
|
1abbee |
+ error(a, "Invalid array entry at %"PRIu64" of %"PRIu64, i, n);
|
|
|
1abbee |
return -EBADMSG;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
@@ -878,7 +866,7 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
for (i = 0; i < sizeof(f->header->reserved); i++)
|
|
|
1abbee |
if (f->header->reserved[i] != 0) {
|
|
|
1abbee |
- error(offsetof(Header, reserved[i]), "reserved field is non-zero");
|
|
|
1abbee |
+ error(offsetof(Header, reserved[i]), "Reserved field is non-zero");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -897,12 +885,12 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
r = journal_file_move_to_object(f, OBJECT_UNUSED, p, &o);
|
|
|
1abbee |
if (r < 0) {
|
|
|
1abbee |
- error(p, "invalid object");
|
|
|
1abbee |
+ error(p, "Invalid object");
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (p > le64toh(f->header->tail_object_offset)) {
|
|
|
1abbee |
- error(offsetof(Header, tail_object_offset), "invalid tail object pointer");
|
|
|
1abbee |
+ error(offsetof(Header, tail_object_offset), "Invalid tail object pointer");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -911,13 +899,13 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
r = journal_file_object_verify(f, p, o);
|
|
|
1abbee |
if (r < 0) {
|
|
|
1abbee |
- error(p, "invalid object contents: %s", strerror(-r));
|
|
|
1abbee |
+ error(p, "Envalid object contents: %s", strerror(-r));
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if ((o->object.flags & OBJECT_COMPRESSED_XZ) &&
|
|
|
1abbee |
(o->object.flags & OBJECT_COMPRESSED_LZ4)) {
|
|
|
1abbee |
- error(p, "objected with double compression");
|
|
|
1abbee |
+ error(p, "Objected with double compression");
|
|
|
1abbee |
r = -EINVAL;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -950,7 +938,7 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
case OBJECT_ENTRY:
|
|
|
1abbee |
if (JOURNAL_HEADER_SEALED(f->header) && n_tags <= 0) {
|
|
|
1abbee |
- error(p, "first entry before first tag");
|
|
|
1abbee |
+ error(p, "First entry before first tag");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -960,21 +948,21 @@ int journal_file_verify(
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(o->entry.realtime) < last_tag_realtime) {
|
|
|
1abbee |
- error(p, "older entry after newer tag");
|
|
|
1abbee |
+ error(p, "Older entry after newer tag");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!entry_seqnum_set &&
|
|
|
1abbee |
le64toh(o->entry.seqnum) != le64toh(f->header->head_entry_seqnum)) {
|
|
|
1abbee |
- error(p, "head entry sequence number incorrect");
|
|
|
1abbee |
+ error(p, "Head entry sequence number incorrect");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (entry_seqnum_set &&
|
|
|
1abbee |
entry_seqnum >= le64toh(o->entry.seqnum)) {
|
|
|
1abbee |
- error(p, "entry sequence number out of synchronization");
|
|
|
1abbee |
+ error(p, "Entry sequence number out of synchronization");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -985,7 +973,7 @@ int journal_file_verify(
|
|
|
1abbee |
if (entry_monotonic_set &&
|
|
|
1abbee |
sd_id128_equal(entry_boot_id, o->entry.boot_id) &&
|
|
|
1abbee |
entry_monotonic > le64toh(o->entry.monotonic)) {
|
|
|
1abbee |
- error(p, "entry timestamp out of synchronization");
|
|
|
1abbee |
+ error(p, "Entry timestamp out of synchronization");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -996,7 +984,7 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
if (!entry_realtime_set &&
|
|
|
1abbee |
le64toh(o->entry.realtime) != le64toh(f->header->head_entry_realtime)) {
|
|
|
1abbee |
- error(p, "head entry realtime timestamp incorrect");
|
|
|
1abbee |
+ error(p, "Head entry realtime timestamp incorrect");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -1009,7 +997,7 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
case OBJECT_DATA_HASH_TABLE:
|
|
|
1abbee |
if (n_data_hash_tables > 1) {
|
|
|
1abbee |
- error(p, "more than one data hash table");
|
|
|
1abbee |
+ error(p, "More than one data hash table");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -1026,14 +1014,14 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
case OBJECT_FIELD_HASH_TABLE:
|
|
|
1abbee |
if (n_field_hash_tables > 1) {
|
|
|
1abbee |
- error(p, "more than one field hash table");
|
|
|
1abbee |
+ error(p, "More than one field hash table");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(f->header->field_hash_table_offset) != p + offsetof(HashTableObject, items) ||
|
|
|
1abbee |
le64toh(f->header->field_hash_table_size) != le64toh(o->object.size) - offsetof(HashTableObject, items)) {
|
|
|
1abbee |
- error(p, "header fields for field hash table invalid");
|
|
|
1abbee |
+ error(p, "Header fields for field hash table invalid");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -1048,7 +1036,7 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
if (p == le64toh(f->header->entry_array_offset)) {
|
|
|
1abbee |
if (found_main_entry_array) {
|
|
|
1abbee |
- error(p, "more than one main entry array");
|
|
|
1abbee |
+ error(p, "More than one main entry array");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -1061,19 +1049,19 @@ int journal_file_verify(
|
|
|
1abbee |
|
|
|
1abbee |
case OBJECT_TAG:
|
|
|
1abbee |
if (!JOURNAL_HEADER_SEALED(f->header)) {
|
|
|
1abbee |
- error(p, "tag object in file without sealing");
|
|
|
1abbee |
+ error(p, "Tag object in file without sealing");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(o->tag.seqnum) != n_tags + 1) {
|
|
|
1abbee |
- error(p, "tag sequence number out of synchronization");
|
|
|
1abbee |
+ error(p, "Tag sequence number out of synchronization");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (le64toh(o->tag.epoch) < last_epoch) {
|
|
|
1abbee |
- error(p, "epoch sequence out of synchronization");
|
|
|
1abbee |
+ error(p, "Epoch sequence out of synchronization");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -1082,7 +1070,7 @@ int journal_file_verify(
|
|
|
1abbee |
if (f->seal) {
|
|
|
1abbee |
uint64_t q, rt;
|
|
|
1abbee |
|
|
|
1abbee |
- debug(p, "checking tag %"PRIu64"...", le64toh(o->tag.seqnum));
|
|
|
1abbee |
+ debug(p, "Checking tag %"PRIu64"...", le64toh(o->tag.seqnum));
|
|
|
1abbee |
|
|
|
1abbee |
rt = f->fss_start_usec + o->tag.epoch * f->fss_interval_usec;
|
|
|
1abbee |
if (entry_realtime_set && entry_realtime >= rt + f->fss_interval_usec) {
|
|
|
1abbee |
@@ -1129,7 +1117,7 @@ int journal_file_verify(
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
|
|
|
1abbee |
if (memcmp(o->tag.tag, gcry_md_read(f->hmac, 0), TAG_LENGTH) != 0) {
|
|
|
1abbee |
- error(p, "tag failed verification");
|
|
|
1abbee |
+ error(p, "Tag failed verification");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -1160,60 +1148,60 @@ int journal_file_verify(
|
|
|
1abbee |
};
|
|
|
1abbee |
|
|
|
1abbee |
if (!found_last && le64toh(f->header->tail_object_offset) != 0) {
|
|
|
1abbee |
- error(le64toh(f->header->tail_object_offset), "tail object pointer dead");
|
|
|
1abbee |
+ error(le64toh(f->header->tail_object_offset), "Tail object pointer dead");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (n_objects != le64toh(f->header->n_objects)) {
|
|
|
1abbee |
- error(offsetof(Header, n_objects), "object number mismatch");
|
|
|
1abbee |
+ error(offsetof(Header, n_objects), "Object number mismatch");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (n_entries != le64toh(f->header->n_entries)) {
|
|
|
1abbee |
- error(offsetof(Header, n_entries), "entry number mismatch");
|
|
|
1abbee |
+ error(offsetof(Header, n_entries), "Entry number mismatch");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (JOURNAL_HEADER_CONTAINS(f->header, n_data) &&
|
|
|
1abbee |
n_data != le64toh(f->header->n_data)) {
|
|
|
1abbee |
- error(offsetof(Header, n_data), "data number mismatch");
|
|
|
1abbee |
+ error(offsetof(Header, n_data), "Data number mismatch");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (JOURNAL_HEADER_CONTAINS(f->header, n_fields) &&
|
|
|
1abbee |
n_fields != le64toh(f->header->n_fields)) {
|
|
|
1abbee |
- error(offsetof(Header, n_fields), "field number mismatch");
|
|
|
1abbee |
+ error(offsetof(Header, n_fields), "Field number mismatch");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (JOURNAL_HEADER_CONTAINS(f->header, n_tags) &&
|
|
|
1abbee |
n_tags != le64toh(f->header->n_tags)) {
|
|
|
1abbee |
- error(offsetof(Header, n_tags), "tag number mismatch");
|
|
|
1abbee |
+ error(offsetof(Header, n_tags), "Tag number mismatch");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (JOURNAL_HEADER_CONTAINS(f->header, n_entry_arrays) &&
|
|
|
1abbee |
n_entry_arrays != le64toh(f->header->n_entry_arrays)) {
|
|
|
1abbee |
- error(offsetof(Header, n_entry_arrays), "entry array number mismatch");
|
|
|
1abbee |
+ error(offsetof(Header, n_entry_arrays), "Entry array number mismatch");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (!found_main_entry_array && le64toh(f->header->entry_array_offset) != 0) {
|
|
|
1abbee |
- error(0, "missing entry array");
|
|
|
1abbee |
+ error(0, "Missing entry array");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (entry_seqnum_set &&
|
|
|
1abbee |
entry_seqnum != le64toh(f->header->tail_entry_seqnum)) {
|
|
|
1abbee |
- error(offsetof(Header, tail_entry_seqnum), "invalid tail seqnum");
|
|
|
1abbee |
+ error(offsetof(Header, tail_entry_seqnum), "Invalid tail seqnum");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
@@ -1221,13 +1209,13 @@ int journal_file_verify(
|
|
|
1abbee |
if (entry_monotonic_set &&
|
|
|
1abbee |
(!sd_id128_equal(entry_boot_id, f->header->boot_id) ||
|
|
|
1abbee |
entry_monotonic != le64toh(f->header->tail_entry_monotonic))) {
|
|
|
1abbee |
- error(0, "invalid tail monotonic timestamp");
|
|
|
1abbee |
+ error(0, "Invalid tail monotonic timestamp");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|
|
|
1abbee |
|
|
|
1abbee |
if (entry_realtime_set && entry_realtime != le64toh(f->header->tail_entry_realtime)) {
|
|
|
1abbee |
- error(0, "invalid tail realtime timestamp");
|
|
|
1abbee |
+ error(0, "Invalid tail realtime timestamp");
|
|
|
1abbee |
r = -EBADMSG;
|
|
|
1abbee |
goto fail;
|
|
|
1abbee |
}
|