naccyde / rpms / systemd

Forked from rpms/systemd a year ago
Clone
87177b
From 7d7655d0cc66288959b41f36ee1c52043cd86b79 Mon Sep 17 00:00:00 2001
87177b
Message-Id: <7d7655d0cc66288959b41f36ee1c52043cd86b79.1637749821.git.aclaudi@redhat.com>
87177b
In-Reply-To: <cef782ca658d695c5ca2d174ba1f89cba6bd84e5.1637749821.git.aclaudi@redhat.com>
87177b
References: <cef782ca658d695c5ca2d174ba1f89cba6bd84e5.1637749821.git.aclaudi@redhat.com>
87177b
From: Andrea Claudi <aclaudi@redhat.com>
87177b
Date: Wed, 24 Nov 2021 11:28:08 +0100
87177b
Subject: [PATCH] configure: fix parsing issue with more than one value per
87177b
 option
87177b
87177b
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2009355
87177b
Upstream Status: iproute2.git commit c330d097
87177b
87177b
commit c330d0979440a1dec4a436fd742bb6e28d195526
87177b
Author: Andrea Claudi <aclaudi@redhat.com>
87177b
Date:   Thu Oct 14 10:50:51 2021 +0200
87177b
87177b
    configure: fix parsing issue with more than one value per option
87177b
87177b
    With commit a9c3d70d902a ("configure: add options ability") users are no
87177b
    more able to provide wrong command lines like:
87177b
87177b
    $ ./configure --include_dir foo bar
87177b
87177b
    The script simply bails out when user provides more than one value for a
87177b
    single option. However, in doing so, it breaks backward compatibility with
87177b
    some packaging system, which expects unknown options to be ignored.
87177b
87177b
    Commit a3272b93725a ("configure: restore backward compatibility") fix this
87177b
    issue, but makes it possible again for users to provide wrong command lines
87177b
    such as the one above.
87177b
87177b
    This fixes the issue simply ignoring autoconf-like options such as
87177b
    '--opt=value'.
87177b
87177b
    Fixes: a3272b93725a ("configure: restore backward compatibility")
87177b
    Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
87177b
    Acked-by: Phil Sutter <phil@nwl.cc>
87177b
    Signed-off-by: David Ahern <dsahern@kernel.org>
87177b
---
87177b
 configure | 4 +++-
87177b
 1 file changed, 3 insertions(+), 1 deletion(-)
87177b
87177b
diff --git a/configure b/configure
87177b
index 0f304206..9ec19a5b 100755
87177b
--- a/configure
87177b
+++ b/configure
87177b
@@ -517,10 +517,12 @@ else
87177b
 				shift 2 ;;
87177b
 			-h | --help)
87177b
 				usage 0 ;;
87177b
+			--*)
87177b
+				shift ;;
87177b
 			"")
87177b
 				break ;;
87177b
 			*)
87177b
-				shift 1 ;;
87177b
+				usage 1 ;;
87177b
 		esac
87177b
 	done
87177b
 fi
87177b
-- 
87177b
2.31.1
87177b