linuxtorvalds / rpms / kernel

Forked from rpms/kernel 2 years ago
Clone
b37f23
From 081008132942c3c50c43d1fded60080cfa8cda91 Mon Sep 17 00:00:00 2001
b37f23
From: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
b37f23
Date: Wed, 26 Oct 2016 13:34:40 +0530
b37f23
Subject: [PATCH 09/11] scsi: mpt3sas: Use the new MPI 2.6 32-bit Atomic
b37f23
 Request Descriptors for SAS35 devices.
b37f23
b37f23
Support Atomic Request Descriptors for Ventura/SAS35 devices.
b37f23
b37f23
Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com>
b37f23
Signed-off-by: Sathya Prakash <sathya.prakash@broadcom.com>
b37f23
Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
b37f23
Reviewed-by: Hannes Reinecke <hare@suse.com>
b37f23
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
b37f23
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
b37f23
---
b37f23
 drivers/scsi/mpt3sas/mpt3sas_base.c      | 141 +++++++++++++++++++++++++++----
b37f23
 drivers/scsi/mpt3sas/mpt3sas_base.h      |  18 ++--
b37f23
 drivers/scsi/mpt3sas/mpt3sas_config.c    |   2 +-
b37f23
 drivers/scsi/mpt3sas/mpt3sas_ctl.c       |  22 ++---
b37f23
 drivers/scsi/mpt3sas/mpt3sas_scsih.c     |  24 +++---
b37f23
 drivers/scsi/mpt3sas/mpt3sas_transport.c |   8 +-
b37f23
 6 files changed, 161 insertions(+), 54 deletions(-)
b37f23
b37f23
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
b37f23
index b26fa23..9ef253b 100644
b37f23
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
b37f23
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
b37f23
@@ -850,7 +850,7 @@ _base_async_event(struct MPT3SAS_ADAPTER *ioc, u8 msix_index, u32 reply)
b37f23
 	ack_request->EventContext = mpi_reply->EventContext;
b37f23
 	ack_request->VF_ID = 0;  /* TODO */
b37f23
 	ack_request->VP_ID = 0;
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 
b37f23
  out:
b37f23
 
b37f23
@@ -2454,15 +2454,15 @@ _base_writeq(__u64 b, volatile void __iomem *addr, spinlock_t *writeq_lock)
b37f23
 #endif
b37f23
 
b37f23
 /**
b37f23
- * mpt3sas_base_put_smid_scsi_io - send SCSI_IO request to firmware
b37f23
+ * _base_put_smid_scsi_io - send SCSI_IO request to firmware
b37f23
  * @ioc: per adapter object
b37f23
  * @smid: system request message index
b37f23
  * @handle: device handle
b37f23
  *
b37f23
  * Return nothing.
b37f23
  */
b37f23
-void
b37f23
-mpt3sas_base_put_smid_scsi_io(struct MPT3SAS_ADAPTER *ioc, u16 smid, u16 handle)
b37f23
+static void
b37f23
+_base_put_smid_scsi_io(struct MPT3SAS_ADAPTER *ioc, u16 smid, u16 handle)
b37f23
 {
b37f23
 	Mpi2RequestDescriptorUnion_t descriptor;
b37f23
 	u64 *request = (u64 *)&descriptor;
b37f23
@@ -2478,15 +2478,15 @@ mpt3sas_base_put_smid_scsi_io(struct MPT3SAS_ADAPTER *ioc, u16 smid, u16 handle)
b37f23
 }
b37f23
 
b37f23
 /**
b37f23
- * mpt3sas_base_put_smid_fast_path - send fast path request to firmware
b37f23
+ * _base_put_smid_fast_path - send fast path request to firmware
b37f23
  * @ioc: per adapter object
b37f23
  * @smid: system request message index
b37f23
  * @handle: device handle
b37f23
  *
b37f23
  * Return nothing.
b37f23
  */
b37f23
-void
b37f23
-mpt3sas_base_put_smid_fast_path(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
+static void
b37f23
+_base_put_smid_fast_path(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
 	u16 handle)
b37f23
 {
b37f23
 	Mpi2RequestDescriptorUnion_t descriptor;
b37f23
@@ -2503,14 +2503,14 @@ mpt3sas_base_put_smid_fast_path(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
 }
b37f23
 
b37f23
 /**
b37f23
- * mpt3sas_base_put_smid_hi_priority - send Task Managment request to firmware
b37f23
+ * _base_put_smid_hi_priority - send Task Management request to firmware
b37f23
  * @ioc: per adapter object
b37f23
  * @smid: system request message index
b37f23
  * @msix_task: msix_task will be same as msix of IO incase of task abort else 0.
b37f23
  * Return nothing.
b37f23
  */
b37f23
-void
b37f23
-mpt3sas_base_put_smid_hi_priority(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
+static void
b37f23
+_base_put_smid_hi_priority(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
 	u16 msix_task)
b37f23
 {
b37f23
 	Mpi2RequestDescriptorUnion_t descriptor;
b37f23
@@ -2527,14 +2527,14 @@ mpt3sas_base_put_smid_hi_priority(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
 }
b37f23
 
b37f23
 /**
b37f23
- * mpt3sas_base_put_smid_default - Default, primarily used for config pages
b37f23
+ * _base_put_smid_default - Default, primarily used for config pages
b37f23
  * @ioc: per adapter object
b37f23
  * @smid: system request message index
b37f23
  *
b37f23
  * Return nothing.
b37f23
  */
b37f23
-void
b37f23
-mpt3sas_base_put_smid_default(struct MPT3SAS_ADAPTER *ioc, u16 smid)
b37f23
+static void
b37f23
+_base_put_smid_default(struct MPT3SAS_ADAPTER *ioc, u16 smid)
b37f23
 {
b37f23
 	Mpi2RequestDescriptorUnion_t descriptor;
b37f23
 	u64 *request = (u64 *)&descriptor;
b37f23
@@ -2549,6 +2549,95 @@ mpt3sas_base_put_smid_default(struct MPT3SAS_ADAPTER *ioc, u16 smid)
b37f23
 }
b37f23
 
b37f23
 /**
b37f23
+* _base_put_smid_scsi_io_atomic - send SCSI_IO request to firmware using
b37f23
+*   Atomic Request Descriptor
b37f23
+* @ioc: per adapter object
b37f23
+* @smid: system request message index
b37f23
+* @handle: device handle, unused in this function, for function type match
b37f23
+*
b37f23
+* Return nothing.
b37f23
+*/
b37f23
+static void
b37f23
+_base_put_smid_scsi_io_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
+	u16 handle)
b37f23
+{
b37f23
+	Mpi26AtomicRequestDescriptor_t descriptor;
b37f23
+	u32 *request = (u32 *)&descriptor;
b37f23
+
b37f23
+	descriptor.RequestFlags = MPI2_REQ_DESCRIPT_FLAGS_SCSI_IO;
b37f23
+	descriptor.MSIxIndex = _base_get_msix_index(ioc);
b37f23
+	descriptor.SMID = cpu_to_le16(smid);
b37f23
+
b37f23
+	writel(cpu_to_le32(*request), &ioc->chip->AtomicRequestDescriptorPost);
b37f23
+}
b37f23
+
b37f23
+/**
b37f23
+ * _base_put_smid_fast_path_atomic - send fast path request to firmware
b37f23
+ * using Atomic Request Descriptor
b37f23
+ * @ioc: per adapter object
b37f23
+ * @smid: system request message index
b37f23
+ * @handle: device handle, unused in this function, for function type match
b37f23
+ * Return nothing
b37f23
+ */
b37f23
+static void
b37f23
+_base_put_smid_fast_path_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
+	u16 handle)
b37f23
+{
b37f23
+	Mpi26AtomicRequestDescriptor_t descriptor;
b37f23
+	u32 *request = (u32 *)&descriptor;
b37f23
+
b37f23
+	descriptor.RequestFlags = MPI25_REQ_DESCRIPT_FLAGS_FAST_PATH_SCSI_IO;
b37f23
+	descriptor.MSIxIndex = _base_get_msix_index(ioc);
b37f23
+	descriptor.SMID = cpu_to_le16(smid);
b37f23
+
b37f23
+	writel(cpu_to_le32(*request), &ioc->chip->AtomicRequestDescriptorPost);
b37f23
+}
b37f23
+
b37f23
+/**
b37f23
+ * _base_put_smid_hi_priority_atomic - send Task Management request to
b37f23
+ * firmware using Atomic Request Descriptor
b37f23
+ * @ioc: per adapter object
b37f23
+ * @smid: system request message index
b37f23
+ * @msix_task: msix_task will be same as msix of IO incase of task abort else 0
b37f23
+ *
b37f23
+ * Return nothing.
b37f23
+ */
b37f23
+static void
b37f23
+_base_put_smid_hi_priority_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
+	u16 msix_task)
b37f23
+{
b37f23
+	Mpi26AtomicRequestDescriptor_t descriptor;
b37f23
+	u32 *request = (u32 *)&descriptor;
b37f23
+
b37f23
+	descriptor.RequestFlags = MPI2_REQ_DESCRIPT_FLAGS_HIGH_PRIORITY;
b37f23
+	descriptor.MSIxIndex = msix_task;
b37f23
+	descriptor.SMID = cpu_to_le16(smid);
b37f23
+
b37f23
+	writel(cpu_to_le32(*request), &ioc->chip->AtomicRequestDescriptorPost);
b37f23
+}
b37f23
+
b37f23
+/**
b37f23
+ * _base_put_smid_default - Default, primarily used for config pages
b37f23
+ * use Atomic Request Descriptor
b37f23
+ * @ioc: per adapter object
b37f23
+ * @smid: system request message index
b37f23
+ *
b37f23
+ * Return nothing.
b37f23
+ */
b37f23
+static void
b37f23
+_base_put_smid_default_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid)
b37f23
+{
b37f23
+	Mpi26AtomicRequestDescriptor_t descriptor;
b37f23
+	u32 *request = (u32 *)&descriptor;
b37f23
+
b37f23
+	descriptor.RequestFlags = MPI2_REQ_DESCRIPT_FLAGS_DEFAULT_TYPE;
b37f23
+	descriptor.MSIxIndex = _base_get_msix_index(ioc);
b37f23
+	descriptor.SMID = cpu_to_le16(smid);
b37f23
+
b37f23
+	writel(cpu_to_le32(*request), &ioc->chip->AtomicRequestDescriptorPost);
b37f23
+}
b37f23
+
b37f23
+/**
b37f23
  * _base_display_OEMs_branding - Display branding string
b37f23
  * @ioc: per adapter object
b37f23
  *
b37f23
@@ -4058,7 +4147,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc,
b37f23
 	    mpi_request->Operation == MPI2_SAS_OP_PHY_LINK_RESET)
b37f23
 		ioc->ioc_link_reset_in_progress = 1;
b37f23
 	init_completion(&ioc->base_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->base_cmds.done,
b37f23
 	    msecs_to_jiffies(10000));
b37f23
 	if ((mpi_request->Operation == MPI2_SAS_OP_PHY_HARD_RESET ||
b37f23
@@ -4160,7 +4249,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc,
b37f23
 	ioc->base_cmds.smid = smid;
b37f23
 	memcpy(request, mpi_request, sizeof(Mpi2SepReply_t));
b37f23
 	init_completion(&ioc->base_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->base_cmds.done,
b37f23
 	    msecs_to_jiffies(10000));
b37f23
 	if (!(ioc->base_cmds.status & MPT3_CMD_COMPLETE)) {
b37f23
@@ -4351,6 +4440,8 @@ _base_get_ioc_facts(struct MPT3SAS_ADAPTER *ioc, int sleep_flag)
b37f23
 	if ((facts->IOCCapabilities &
b37f23
 	      MPI2_IOCFACTS_CAPABILITY_RDPQ_ARRAY_CAPABLE))
b37f23
 		ioc->rdpq_array_capable = 1;
b37f23
+	if (facts->IOCCapabilities & MPI26_IOCFACTS_CAPABILITY_ATOMIC_REQ)
b37f23
+		ioc->atomic_desc_capable = 1;
b37f23
 	facts->FWVersion.Word = le32_to_cpu(mpi_reply.FWVersion.Word);
b37f23
 	facts->IOCRequestFrameSize =
b37f23
 	    le16_to_cpu(mpi_reply.IOCRequestFrameSize);
b37f23
@@ -4582,7 +4673,7 @@ _base_send_port_enable(struct MPT3SAS_ADAPTER *ioc, int sleep_flag)
b37f23
 	mpi_request->Function = MPI2_FUNCTION_PORT_ENABLE;
b37f23
 
b37f23
 	init_completion(&ioc->port_enable_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->port_enable_cmds.done,
b37f23
 	    300*HZ);
b37f23
 	if (!(ioc->port_enable_cmds.status & MPT3_CMD_COMPLETE)) {
b37f23
@@ -4646,7 +4737,7 @@ mpt3sas_port_enable(struct MPT3SAS_ADAPTER *ioc)
b37f23
 	memset(mpi_request, 0, sizeof(Mpi2PortEnableRequest_t));
b37f23
 	mpi_request->Function = MPI2_FUNCTION_PORT_ENABLE;
b37f23
 
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	return 0;
b37f23
 }
b37f23
 
b37f23
@@ -4767,7 +4858,7 @@ _base_event_notification(struct MPT3SAS_ADAPTER *ioc, int sleep_flag)
b37f23
 		mpi_request->EventMasks[i] =
b37f23
 		    cpu_to_le32(ioc->event_masks[i]);
b37f23
 	init_completion(&ioc->base_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->base_cmds.done, 30*HZ);
b37f23
 	if (!(ioc->base_cmds.status & MPT3_CMD_COMPLETE)) {
b37f23
 		pr_err(MPT3SAS_FMT "%s: timeout\n",
b37f23
@@ -5316,9 +5407,23 @@ mpt3sas_base_attach(struct MPT3SAS_ADAPTER *ioc)
b37f23
 		ioc->build_sg = &_base_build_sg_ieee;
b37f23
 		ioc->build_zero_len_sge = &_base_build_zero_len_sge_ieee;
b37f23
 		ioc->sge_size_ieee = sizeof(Mpi2IeeeSgeSimple64_t);
b37f23
+
b37f23
 		break;
b37f23
 	}
b37f23
 
b37f23
+	if (ioc->atomic_desc_capable) {
b37f23
+		ioc->put_smid_default = &_base_put_smid_default_atomic;
b37f23
+		ioc->put_smid_scsi_io = &_base_put_smid_scsi_io_atomic;
b37f23
+		ioc->put_smid_fast_path = &_base_put_smid_fast_path_atomic;
b37f23
+		ioc->put_smid_hi_priority = &_base_put_smid_hi_priority_atomic;
b37f23
+	} else {
b37f23
+		ioc->put_smid_default = &_base_put_smid_default;
b37f23
+		ioc->put_smid_scsi_io = &_base_put_smid_scsi_io;
b37f23
+		ioc->put_smid_fast_path = &_base_put_smid_fast_path;
b37f23
+		ioc->put_smid_hi_priority = &_base_put_smid_hi_priority;
b37f23
+	}
b37f23
+
b37f23
+
b37f23
 	/*
b37f23
 	 * These function pointers for other requests that don't
b37f23
 	 * the require IEEE scatter gather elements.
b37f23
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h
b37f23
index 240c360..b8c8be4 100644
b37f23
--- a/drivers/scsi/mpt3sas/mpt3sas_base.h
b37f23
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.h
b37f23
@@ -740,7 +740,10 @@ typedef void (*MPT_BUILD_SG)(struct MPT3SAS_ADAPTER *ioc, void *psge,
b37f23
 typedef void (*MPT_BUILD_ZERO_LEN_SGE)(struct MPT3SAS_ADAPTER *ioc,
b37f23
 		void *paddr);
b37f23
 
b37f23
-
b37f23
+/* To support atomic and non atomic descriptors*/
b37f23
+typedef void (*PUT_SMID_IO_FP_HIP) (struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
+	u16 funcdep);
b37f23
+typedef void (*PUT_SMID_DEFAULT) (struct MPT3SAS_ADAPTER *ioc, u16 smid);
b37f23
 
b37f23
 /* IOC Facts and Port Facts converted from little endian to cpu */
b37f23
 union mpi3_version_union {
b37f23
@@ -1208,6 +1211,12 @@ struct MPT3SAS_ADAPTER {
b37f23
 	void		*device_remove_in_progress;
b37f23
 	u16		device_remove_in_progress_sz;
b37f23
 	u8		is_gen35_ioc;
b37f23
+	u8		atomic_desc_capable;
b37f23
+	PUT_SMID_IO_FP_HIP put_smid_scsi_io;
b37f23
+	PUT_SMID_IO_FP_HIP put_smid_fast_path;
b37f23
+	PUT_SMID_IO_FP_HIP put_smid_hi_priority;
b37f23
+	PUT_SMID_DEFAULT put_smid_default;
b37f23
+
b37f23
 };
b37f23
 
b37f23
 typedef u8 (*MPT_CALLBACK)(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index,
b37f23
@@ -1253,13 +1262,6 @@ u16 mpt3sas_base_get_smid_scsiio(struct MPT3SAS_ADAPTER *ioc, u8 cb_idx,
b37f23
 
b37f23
 u16 mpt3sas_base_get_smid(struct MPT3SAS_ADAPTER *ioc, u8 cb_idx);
b37f23
 void mpt3sas_base_free_smid(struct MPT3SAS_ADAPTER *ioc, u16 smid);
b37f23
-void mpt3sas_base_put_smid_scsi_io(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
-	u16 handle);
b37f23
-void mpt3sas_base_put_smid_fast_path(struct MPT3SAS_ADAPTER *ioc, u16 smid,
b37f23
-	u16 handle);
b37f23
-void mpt3sas_base_put_smid_hi_priority(struct MPT3SAS_ADAPTER *ioc,
b37f23
-	u16 smid, u16 msix_task);
b37f23
-void mpt3sas_base_put_smid_default(struct MPT3SAS_ADAPTER *ioc, u16 smid);
b37f23
 void mpt3sas_base_initialize_callback_handler(void);
b37f23
 u8 mpt3sas_base_register_callback_handler(MPT_CALLBACK cb_func);
b37f23
 void mpt3sas_base_release_callback_handler(u8 cb_idx);
b37f23
diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c
b37f23
index a6914ec..b024e14 100644
b37f23
--- a/drivers/scsi/mpt3sas/mpt3sas_config.c
b37f23
+++ b/drivers/scsi/mpt3sas/mpt3sas_config.c
b37f23
@@ -385,7 +385,7 @@ _config_request(struct MPT3SAS_ADAPTER *ioc, Mpi2ConfigRequest_t
b37f23
 	memcpy(config_request, mpi_request, sizeof(Mpi2ConfigRequest_t));
b37f23
 	_config_display_some_debug(ioc, smid, "config_request", NULL);
b37f23
 	init_completion(&ioc->config_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->config_cmds.done,
b37f23
 	    timeout*HZ);
b37f23
 	if (!(ioc->config_cmds.status & MPT3_CMD_COMPLETE)) {
b37f23
diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
b37f23
index a66c0c8..8273e8c 100644
b37f23
--- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
b37f23
+++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
b37f23
@@ -813,9 +813,9 @@ _ctl_do_mpt_command(struct MPT3SAS_ADAPTER *ioc, struct mpt3_ioctl_command karg,
b37f23
 		ioc->build_sg(ioc, psge, data_out_dma, data_out_sz,
b37f23
 		    data_in_dma, data_in_sz);
b37f23
 		if (mpi_request->Function == MPI2_FUNCTION_SCSI_IO_REQUEST)
b37f23
-			mpt3sas_base_put_smid_scsi_io(ioc, smid, device_handle);
b37f23
+			ioc->put_smid_scsi_io(ioc, smid, device_handle);
b37f23
 		else
b37f23
-			mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+			ioc->put_smid_default(ioc, smid);
b37f23
 		break;
b37f23
 	}
b37f23
 	case MPI2_FUNCTION_SCSI_TASK_MGMT:
b37f23
@@ -850,7 +850,7 @@ _ctl_do_mpt_command(struct MPT3SAS_ADAPTER *ioc, struct mpt3_ioctl_command karg,
b37f23
 		    tm_request->DevHandle));
b37f23
 		ioc->build_sg_mpi(ioc, psge, data_out_dma, data_out_sz,
b37f23
 		    data_in_dma, data_in_sz);
b37f23
-		mpt3sas_base_put_smid_hi_priority(ioc, smid, 0);
b37f23
+		ioc->put_smid_hi_priority(ioc, smid, 0);
b37f23
 		break;
b37f23
 	}
b37f23
 	case MPI2_FUNCTION_SMP_PASSTHROUGH:
b37f23
@@ -881,7 +881,7 @@ _ctl_do_mpt_command(struct MPT3SAS_ADAPTER *ioc, struct mpt3_ioctl_command karg,
b37f23
 		}
b37f23
 		ioc->build_sg(ioc, psge, data_out_dma, data_out_sz, data_in_dma,
b37f23
 		    data_in_sz);
b37f23
-		mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+		ioc->put_smid_default(ioc, smid);
b37f23
 		break;
b37f23
 	}
b37f23
 	case MPI2_FUNCTION_SATA_PASSTHROUGH:
b37f23
@@ -896,7 +896,7 @@ _ctl_do_mpt_command(struct MPT3SAS_ADAPTER *ioc, struct mpt3_ioctl_command karg,
b37f23
 		}
b37f23
 		ioc->build_sg(ioc, psge, data_out_dma, data_out_sz, data_in_dma,
b37f23
 		    data_in_sz);
b37f23
-		mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+		ioc->put_smid_default(ioc, smid);
b37f23
 		break;
b37f23
 	}
b37f23
 	case MPI2_FUNCTION_FW_DOWNLOAD:
b37f23
@@ -904,7 +904,7 @@ _ctl_do_mpt_command(struct MPT3SAS_ADAPTER *ioc, struct mpt3_ioctl_command karg,
b37f23
 	{
b37f23
 		ioc->build_sg(ioc, psge, data_out_dma, data_out_sz, data_in_dma,
b37f23
 		    data_in_sz);
b37f23
-		mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+		ioc->put_smid_default(ioc, smid);
b37f23
 		break;
b37f23
 	}
b37f23
 	case MPI2_FUNCTION_TOOLBOX:
b37f23
@@ -919,7 +919,7 @@ _ctl_do_mpt_command(struct MPT3SAS_ADAPTER *ioc, struct mpt3_ioctl_command karg,
b37f23
 			ioc->build_sg_mpi(ioc, psge, data_out_dma, data_out_sz,
b37f23
 				data_in_dma, data_in_sz);
b37f23
 		}
b37f23
-		mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+		ioc->put_smid_default(ioc, smid);
b37f23
 		break;
b37f23
 	}
b37f23
 	case MPI2_FUNCTION_SAS_IO_UNIT_CONTROL:
b37f23
@@ -938,7 +938,7 @@ _ctl_do_mpt_command(struct MPT3SAS_ADAPTER *ioc, struct mpt3_ioctl_command karg,
b37f23
 	default:
b37f23
 		ioc->build_sg_mpi(ioc, psge, data_out_dma, data_out_sz,
b37f23
 		    data_in_dma, data_in_sz);
b37f23
-		mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+		ioc->put_smid_default(ioc, smid);
b37f23
 		break;
b37f23
 	}
b37f23
 
b37f23
@@ -1533,7 +1533,7 @@ _ctl_diag_register_2(struct MPT3SAS_ADAPTER *ioc,
b37f23
 			cpu_to_le32(ioc->product_specific[buffer_type][i]);
b37f23
 
b37f23
 	init_completion(&ioc->ctl_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->ctl_cmds.done,
b37f23
 	    MPT3_IOCTL_DEFAULT_TIMEOUT*HZ);
b37f23
 
b37f23
@@ -1882,7 +1882,7 @@ mpt3sas_send_diag_release(struct MPT3SAS_ADAPTER *ioc, u8 buffer_type,
b37f23
 	mpi_request->VP_ID = 0;
b37f23
 
b37f23
 	init_completion(&ioc->ctl_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->ctl_cmds.done,
b37f23
 	    MPT3_IOCTL_DEFAULT_TIMEOUT*HZ);
b37f23
 
b37f23
@@ -2150,7 +2150,7 @@ _ctl_diag_read_buffer(struct MPT3SAS_ADAPTER *ioc, void __user *arg)
b37f23
 	mpi_request->VP_ID = 0;
b37f23
 
b37f23
 	init_completion(&ioc->ctl_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->ctl_cmds.done,
b37f23
 	    MPT3_IOCTL_DEFAULT_TIMEOUT*HZ);
b37f23
 
b37f23
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b37f23
index 0ff2ed3..0dcf826 100644
b37f23
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b37f23
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b37f23
@@ -2339,7 +2339,7 @@ mpt3sas_scsih_issue_tm(struct MPT3SAS_ADAPTER *ioc, u16 handle, uint channel,
b37f23
 		msix_task = scsi_lookup->msix_io;
b37f23
 	else
b37f23
 		msix_task = 0;
b37f23
-	mpt3sas_base_put_smid_hi_priority(ioc, smid, msix_task);
b37f23
+	ioc->put_smid_hi_priority(ioc, smid, msix_task);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->tm_cmds.done, timeout*HZ);
b37f23
 	if (!(ioc->tm_cmds.status & MPT3_CMD_COMPLETE)) {
b37f23
 		pr_err(MPT3SAS_FMT "%s: timeout\n",
b37f23
@@ -3252,7 +3252,7 @@ _scsih_tm_tr_send(struct MPT3SAS_ADAPTER *ioc, u16 handle)
b37f23
 	mpi_request->DevHandle = cpu_to_le16(handle);
b37f23
 	mpi_request->TaskType = MPI2_SCSITASKMGMT_TASKTYPE_TARGET_RESET;
b37f23
 	set_bit(handle, ioc->device_remove_in_progress);
b37f23
-	mpt3sas_base_put_smid_hi_priority(ioc, smid, 0);
b37f23
+	ioc->put_smid_hi_priority(ioc, smid, 0);
b37f23
 	mpt3sas_trigger_master(ioc, MASTER_TRIGGER_DEVICE_REMOVAL);
b37f23
 
b37f23
 out:
b37f23
@@ -3351,7 +3351,7 @@ _scsih_tm_tr_complete(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index,
b37f23
 	mpi_request->Function = MPI2_FUNCTION_SAS_IO_UNIT_CONTROL;
b37f23
 	mpi_request->Operation = MPI2_SAS_OP_REMOVE_DEVICE;
b37f23
 	mpi_request->DevHandle = mpi_request_tm->DevHandle;
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid_sas_ctrl);
b37f23
+	ioc->put_smid_default(ioc, smid_sas_ctrl);
b37f23
 
b37f23
 	return _scsih_check_for_pending_tm(ioc, smid);
b37f23
 }
b37f23
@@ -3446,7 +3446,7 @@ _scsih_tm_tr_volume_send(struct MPT3SAS_ADAPTER *ioc, u16 handle)
b37f23
 	mpi_request->Function = MPI2_FUNCTION_SCSI_TASK_MGMT;
b37f23
 	mpi_request->DevHandle = cpu_to_le16(handle);
b37f23
 	mpi_request->TaskType = MPI2_SCSITASKMGMT_TASKTYPE_TARGET_RESET;
b37f23
-	mpt3sas_base_put_smid_hi_priority(ioc, smid, 0);
b37f23
+	ioc->put_smid_hi_priority(ioc, smid, 0);
b37f23
 }
b37f23
 
b37f23
 /**
b37f23
@@ -3538,7 +3538,7 @@ _scsih_issue_delayed_event_ack(struct MPT3SAS_ADAPTER *ioc, u16 smid, u16 event,
b37f23
 	ack_request->EventContext = event_context;
b37f23
 	ack_request->VF_ID = 0;  /* TODO */
b37f23
 	ack_request->VP_ID = 0;
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 }
b37f23
 
b37f23
 /**
b37f23
@@ -3595,7 +3595,7 @@ _scsih_issue_delayed_sas_io_unit_ctrl(struct MPT3SAS_ADAPTER *ioc,
b37f23
 	mpi_request->Function = MPI2_FUNCTION_SAS_IO_UNIT_CONTROL;
b37f23
 	mpi_request->Operation = MPI2_SAS_OP_REMOVE_DEVICE;
b37f23
 	mpi_request->DevHandle = handle;
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 }
b37f23
 
b37f23
 /**
b37f23
@@ -4218,12 +4218,12 @@ scsih_qcmd(struct Scsi_Host *shost, struct scsi_cmnd *scmd)
b37f23
 		if (sas_target_priv_data->flags & MPT_TARGET_FASTPATH_IO) {
b37f23
 			mpi_request->IoFlags = cpu_to_le16(scmd->cmd_len |
b37f23
 			    MPI25_SCSIIO_IOFLAGS_FAST_PATH);
b37f23
-			mpt3sas_base_put_smid_fast_path(ioc, smid, handle);
b37f23
+			ioc->put_smid_fast_path(ioc, smid, handle);
b37f23
 		} else
b37f23
-			mpt3sas_base_put_smid_scsi_io(ioc, smid,
b37f23
+			ioc->put_smid_scsi_io(ioc, smid,
b37f23
 			    le16_to_cpu(mpi_request->DevHandle));
b37f23
 	} else
b37f23
-		mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+		ioc->put_smid_default(ioc, smid);
b37f23
 	return 0;
b37f23
 
b37f23
  out:
b37f23
@@ -4719,7 +4719,7 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index, u32 reply)
b37f23
 		memcpy(mpi_request->CDB.CDB32, scmd->cmnd, scmd->cmd_len);
b37f23
 		mpi_request->DevHandle =
b37f23
 		    cpu_to_le16(sas_device_priv_data->sas_target->handle);
b37f23
-		mpt3sas_base_put_smid_scsi_io(ioc, smid,
b37f23
+		ioc->put_smid_scsi_io(ioc, smid,
b37f23
 		    sas_device_priv_data->sas_target->handle);
b37f23
 		return 0;
b37f23
 	}
b37f23
@@ -6330,7 +6330,7 @@ _scsih_ir_fastpath(struct MPT3SAS_ADAPTER *ioc, u16 handle, u8 phys_disk_num)
b37f23
 	    handle, phys_disk_num));
b37f23
 
b37f23
 	init_completion(&ioc->scsih_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	wait_for_completion_timeout(&ioc->scsih_cmds.done, 10*HZ);
b37f23
 
b37f23
 	if (!(ioc->scsih_cmds.status & MPT3_CMD_COMPLETE)) {
b37f23
@@ -8180,7 +8180,7 @@ _scsih_ir_shutdown(struct MPT3SAS_ADAPTER *ioc)
b37f23
 	if (!ioc->hide_ir_msg)
b37f23
 		pr_info(MPT3SAS_FMT "IR shutdown (sending)\n", ioc->name);
b37f23
 	init_completion(&ioc->scsih_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	wait_for_completion_timeout(&ioc->scsih_cmds.done, 10*HZ);
b37f23
 
b37f23
 	if (!(ioc->scsih_cmds.status & MPT3_CMD_COMPLETE)) {
b37f23
diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
b37f23
index a01b235..4b7c32b 100644
b37f23
--- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
b37f23
+++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
b37f23
@@ -393,7 +393,7 @@ _transport_expander_report_manufacture(struct MPT3SAS_ADAPTER *ioc,
b37f23
 		"report_manufacture - send to sas_addr(0x%016llx)\n",
b37f23
 		ioc->name, (unsigned long long)sas_address));
b37f23
 	init_completion(&ioc->transport_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->transport_cmds.done,
b37f23
 	    10*HZ);
b37f23
 
b37f23
@@ -1197,7 +1197,7 @@ _transport_get_expander_phy_error_log(struct MPT3SAS_ADAPTER *ioc,
b37f23
 		ioc->name, (unsigned long long)phy->identify.sas_address,
b37f23
 		phy->number));
b37f23
 	init_completion(&ioc->transport_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->transport_cmds.done,
b37f23
 	    10*HZ);
b37f23
 
b37f23
@@ -1516,7 +1516,7 @@ _transport_expander_phy_control(struct MPT3SAS_ADAPTER *ioc,
b37f23
 		ioc->name, (unsigned long long)phy->identify.sas_address,
b37f23
 		phy->number, phy_operation));
b37f23
 	init_completion(&ioc->transport_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->transport_cmds.done,
b37f23
 	    10*HZ);
b37f23
 
b37f23
@@ -2036,7 +2036,7 @@ _transport_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy,
b37f23
 		"%s - sending smp request\n", ioc->name, __func__));
b37f23
 
b37f23
 	init_completion(&ioc->transport_cmds.done);
b37f23
-	mpt3sas_base_put_smid_default(ioc, smid);
b37f23
+	ioc->put_smid_default(ioc, smid);
b37f23
 	timeleft = wait_for_completion_timeout(&ioc->transport_cmds.done,
b37f23
 	    10*HZ);
b37f23
 
b37f23
-- 
b37f23
1.8.3.1
b37f23