ignatenkobrain / rpms / nginx

Forked from rpms/nginx 2 years ago
Clone
8f9dab
diff --git a/src/event/ngx_event_openssl.c b/src/event/ngx_event_openssl.c
8f9dab
index 2b0c5e6..9278087 100644
8f9dab
--- a/src/event/ngx_event_openssl.c
8f9dab
+++ b/src/event/ngx_event_openssl.c
8f9dab
@@ -258,6 +258,8 @@ ngx_ssl_init(ngx_log_t *log)
8f9dab
 ngx_int_t
8f9dab
 ngx_ssl_create(ngx_ssl_t *ssl, ngx_uint_t protocols, void *data)
8f9dab
 {
8f9dab
+    ngx_uint_t prot = NGX_SSL_NO_PROT;
8f9dab
+
8f9dab
     ssl->ctx = SSL_CTX_new(SSLv23_method());
8f9dab
 
8f9dab
     if (ssl->ctx == NULL) {
8f9dab
@@ -322,49 +324,54 @@ ngx_ssl_create(ngx_ssl_t *ssl, ngx_uint_t protocols, void *data)
8f9dab
 
8f9dab
     SSL_CTX_set_options(ssl->ctx, SSL_OP_SINGLE_DH_USE);
8f9dab
 
8f9dab
-#if OPENSSL_VERSION_NUMBER >= 0x009080dfL
8f9dab
-    /* only in 0.9.8m+ */
8f9dab
-    SSL_CTX_clear_options(ssl->ctx,
8f9dab
-                          SSL_OP_NO_SSLv2|SSL_OP_NO_SSLv3|SSL_OP_NO_TLSv1);
8f9dab
-#endif
8f9dab
-
8f9dab
-    if (!(protocols & NGX_SSL_SSLv2)) {
8f9dab
-        SSL_CTX_set_options(ssl->ctx, SSL_OP_NO_SSLv2);
8f9dab
-    }
8f9dab
-    if (!(protocols & NGX_SSL_SSLv3)) {
8f9dab
-        SSL_CTX_set_options(ssl->ctx, SSL_OP_NO_SSLv3);
8f9dab
-    }
8f9dab
-    if (!(protocols & NGX_SSL_TLSv1)) {
8f9dab
-        SSL_CTX_set_options(ssl->ctx, SSL_OP_NO_TLSv1);
8f9dab
-    }
8f9dab
-#ifdef SSL_OP_NO_TLSv1_1
8f9dab
-    SSL_CTX_clear_options(ssl->ctx, SSL_OP_NO_TLSv1_1);
8f9dab
-    if (!(protocols & NGX_SSL_TLSv1_1)) {
8f9dab
-        SSL_CTX_set_options(ssl->ctx, SSL_OP_NO_TLSv1_1);
8f9dab
-    }
8f9dab
+    if (protocols){
8f9dab
+#ifdef SSL_OP_NO_TLSv1_3
8f9dab
+        if (protocols & NGX_SSL_TLSv1_3) {
8f9dab
+            prot = TLS1_3_VERSION;
8f9dab
+        } else
8f9dab
 #endif
8f9dab
 #ifdef SSL_OP_NO_TLSv1_2
8f9dab
-    SSL_CTX_clear_options(ssl->ctx, SSL_OP_NO_TLSv1_2);
8f9dab
-    if (!(protocols & NGX_SSL_TLSv1_2)) {
8f9dab
-        SSL_CTX_set_options(ssl->ctx, SSL_OP_NO_TLSv1_2);
8f9dab
-    }
8f9dab
+        if (protocols & NGX_SSL_TLSv1_2) {
8f9dab
+            prot =  TLS1_2_VERSION;
8f9dab
+        } else
8f9dab
 #endif
8f9dab
-#ifdef SSL_OP_NO_TLSv1_3
8f9dab
-    SSL_CTX_clear_options(ssl->ctx, SSL_OP_NO_TLSv1_3);
8f9dab
-    if (!(protocols & NGX_SSL_TLSv1_3)) {
8f9dab
-        SSL_CTX_set_options(ssl->ctx, SSL_OP_NO_TLSv1_3);
8f9dab
-    }
8f9dab
+#ifdef SSL_OP_NO_TLSv1_1
8f9dab
+        if (protocols & NGX_SSL_TLSv1_1) {
8f9dab
+            prot = TLS1_1_VERSION;
8f9dab
+        } else
8f9dab
 #endif
8f9dab
+        if (protocols & NGX_SSL_TLSv1) {
8f9dab
+            prot = TLS1_VERSION;
8f9dab
+        }
8f9dab
+
8f9dab
+        if (prot == NGX_SSL_NO_PROT) {
8f9dab
+                    ngx_ssl_error(NGX_LOG_EMERG, ssl->log, 0,
8f9dab
+                      "No SSL protocols available [hint: ssl_protocols]");
8f9dab
+            return NGX_ERROR;
8f9dab
+        }
8f9dab
 
8f9dab
-#ifdef SSL_CTX_set_min_proto_version
8f9dab
-    SSL_CTX_set_min_proto_version(ssl->ctx, 0);
8f9dab
-    SSL_CTX_set_max_proto_version(ssl->ctx, TLS1_2_VERSION);
8f9dab
+        SSL_CTX_set_max_proto_version(ssl->ctx, prot);
8f9dab
+
8f9dab
+        /* Now, we have to scan for minimal protocol version,
8f9dab
+         *without allowing holes between min and max*/
8f9dab
+#if SSL_OP_NO_TLSv1_3
8f9dab
+        if ((prot == TLS1_3_VERSION) && (protocols & NGX_SSL_TLSv1_2)) {
8f9dab
+            prot = TLS1_2_VERSION;
8f9dab
+        }
8f9dab
 #endif
8f9dab
 
8f9dab
-#ifdef TLS1_3_VERSION
8f9dab
-    SSL_CTX_set_min_proto_version(ssl->ctx, 0);
8f9dab
-    SSL_CTX_set_max_proto_version(ssl->ctx, TLS1_3_VERSION);
8f9dab
+#ifdef SSL_OP_NO_TLSv1_1
8f9dab
+        if ((prot == TLS1_2_VERSION) && (protocols & NGX_SSL_TLSv1_1)) {
8f9dab
+            prot = TLS1_1_VERSION;
8f9dab
+        }
8f9dab
+#endif
8f9dab
+#ifdef SSL_OP_NO_TLSv1_2
8f9dab
+        if ((prot == TLS1_1_VERSION) && (protocols & NGX_SSL_TLSv1)) {
8f9dab
+            prot = TLS1_VERSION;
8f9dab
+        }
8f9dab
 #endif
8f9dab
+        SSL_CTX_set_min_proto_version(ssl->ctx, prot);
8f9dab
+    }
8f9dab
 
8f9dab
 #ifdef SSL_OP_NO_COMPRESSION
8f9dab
     SSL_CTX_set_options(ssl->ctx, SSL_OP_NO_COMPRESSION);
8f9dab
diff --git a/src/event/ngx_event_openssl.h b/src/event/ngx_event_openssl.h
8f9dab
index 329760d..5cee113 100644
8f9dab
--- a/src/event/ngx_event_openssl.h
8f9dab
+++ b/src/event/ngx_event_openssl.h
8f9dab
@@ -152,6 +152,7 @@ typedef struct {
8f9dab
 #endif
8f9dab
 
8f9dab
 
8f9dab
+#define NGX_SSL_NO_PROT  0x0000
8f9dab
 #define NGX_SSL_SSLv2    0x0002
8f9dab
 #define NGX_SSL_SSLv3    0x0004
8f9dab
 #define NGX_SSL_TLSv1    0x0008
8f9dab
diff --git a/src/http/modules/ngx_http_ssl_module.c b/src/http/modules/ngx_http_ssl_module.c
8f9dab
index a47d696..94f30db 100644
8f9dab
--- a/src/http/modules/ngx_http_ssl_module.c
8f9dab
+++ b/src/http/modules/ngx_http_ssl_module.c
8f9dab
@@ -671,8 +671,7 @@ ngx_http_ssl_merge_srv_conf(ngx_conf_t *cf, void *parent, void *child)
8f9dab
     ngx_conf_merge_value(conf->reject_handshake, prev->reject_handshake, 0);
8f9dab
 
8f9dab
     ngx_conf_merge_bitmask_value(conf->protocols, prev->protocols,
8f9dab
-                         (NGX_CONF_BITMASK_SET|NGX_SSL_TLSv1
8f9dab
-                          |NGX_SSL_TLSv1_1|NGX_SSL_TLSv1_2));
8f9dab
+                         0)
8f9dab
 
8f9dab
     ngx_conf_merge_size_value(conf->buffer_size, prev->buffer_size,
8f9dab
                          NGX_SSL_BUFSIZE);
8f9dab
diff --git a/src/mail/ngx_mail_ssl_module.c b/src/mail/ngx_mail_ssl_module.c
8f9dab
index 7eae83e..8328560 100644
8f9dab
--- a/src/mail/ngx_mail_ssl_module.c
8f9dab
+++ b/src/mail/ngx_mail_ssl_module.c
8f9dab
@@ -306,8 +306,7 @@ ngx_mail_ssl_merge_conf(ngx_conf_t *cf, void *parent, void *child)
8f9dab
                          prev->prefer_server_ciphers, 0);
8f9dab
 
8f9dab
     ngx_conf_merge_bitmask_value(conf->protocols, prev->protocols,
8f9dab
-                         (NGX_CONF_BITMASK_SET|NGX_SSL_TLSv1
8f9dab
-                          |NGX_SSL_TLSv1_1|NGX_SSL_TLSv1_2));
8f9dab
+                         0);
8f9dab
 
8f9dab
     ngx_conf_merge_uint_value(conf->verify, prev->verify, 0);
8f9dab
     ngx_conf_merge_uint_value(conf->verify_depth, prev->verify_depth, 1);
8f9dab
diff --git a/src/stream/ngx_stream_ssl_module.c b/src/stream/ngx_stream_ssl_module.c
8f9dab
index d8c0471..cef590d 100644
8f9dab
--- a/src/stream/ngx_stream_ssl_module.c
8f9dab
+++ b/src/stream/ngx_stream_ssl_module.c
8f9dab
@@ -641,8 +641,7 @@ ngx_stream_ssl_merge_conf(ngx_conf_t *cf, void *parent, void *child)
8f9dab
                          prev->prefer_server_ciphers, 0);
8f9dab
 
8f9dab
     ngx_conf_merge_bitmask_value(conf->protocols, prev->protocols,
8f9dab
-                         (NGX_CONF_BITMASK_SET|NGX_SSL_TLSv1
8f9dab
-                          |NGX_SSL_TLSv1_1|NGX_SSL_TLSv1_2));
8f9dab
+                         0);
8f9dab
 
8f9dab
     ngx_conf_merge_uint_value(conf->verify, prev->verify, 0);
8f9dab
     ngx_conf_merge_uint_value(conf->verify_depth, prev->verify_depth, 1);