From c0d527f9ea9786712b86b5b51c6dab074a66342d Mon Sep 17 00:00:00 2001 From: Tomas Halman Date: Mon, 1 Oct 2018 15:49:06 +0200 Subject: [PATCH] confdb: log an error when domain is misconfigured We need to inform user that there is misconfiguration and particular domain will not be started. Resolves: https://pagure.io/SSSD/sssd/issue/3827 Reviewed-by: Jakub Hrozek (cherry picked from commit 081b18e75c746f9a2ad1fb412c825293090311f8) --- src/confdb/confdb.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c index 954c3ba766617f7cfcf637d9143c891bd998d7ff..2f3d90087e640f77835400b11184b684852d7fda 100644 --- a/src/confdb/confdb.c +++ b/src/confdb/confdb.c @@ -39,6 +39,9 @@ #define SAME_DOMAINS_ERROR_MSG "Domain '%s' is the same as or differs only "\ "in case from domain '%s'.\n" +#define RETRIEVE_DOMAIN_ERROR_MSG "Error (%d [%s]) retrieving domain [%s], "\ + "skipping!\n" + static char *prepend_cn(char *str, int *slen, const char *comp, int clen) { char *ret; @@ -1522,8 +1525,12 @@ int confdb_get_domains(struct confdb_ctx *cdb, ret = confdb_get_domain_internal(cdb, cdb, domlist[i], &domain); if (ret) { DEBUG(SSSDBG_FATAL_FAILURE, - "Error (%d [%s]) retrieving domain [%s], skipping!\n", + RETRIEVE_DOMAIN_ERROR_MSG, ret, sss_strerror(ret), domlist[i]); + sss_log(SSS_LOG_CRIT, + RETRIEVE_DOMAIN_ERROR_MSG, + ret, sss_strerror(ret), domlist[i]); + continue; } -- 2.14.4