dpward / rpms / sssd

Forked from rpms/sssd 3 years ago
Clone

Blame SOURCES/0087-KCM-Deleting-a-non-existent-ccache-should-not-yield-.patch

71e593
From 02c15d40efe6dd9107528469904f1315fca37416 Mon Sep 17 00:00:00 2001
71e593
From: Jakub Hrozek <jhrozek@redhat.com>
71e593
Date: Thu, 3 Jan 2019 15:07:59 +0100
71e593
Subject: [PATCH 87/88] KCM: Deleting a non-existent ccache should not yield an
71e593
 error
71e593
71e593
Resolves:
71e593
https://pagure.io/SSSD/sssd/issue/3910
71e593
71e593
When the KCM destroy operation is called, it receives a name as an input. If
71e593
the name cannot be found, we would currently return KRB5_CC_NOTFOUND. But
71e593
other ccache types return KRB5_FCC_NOFILE in that case and e.g. utilities
71e593
like kdestroy special case KRB5_FCC_NOFILE to be non-fatal.
71e593
71e593
Reviewed-by: Tomas Halman <thalman@redhat.com>
71e593
---
71e593
 src/responder/kcm/kcmsrv_ops.c | 3 ++-
71e593
 1 file changed, 2 insertions(+), 1 deletion(-)
71e593
71e593
diff --git a/src/responder/kcm/kcmsrv_ops.c b/src/responder/kcm/kcmsrv_ops.c
71e593
index 1e229adc4..9352909f4 100644
71e593
--- a/src/responder/kcm/kcmsrv_ops.c
71e593
+++ b/src/responder/kcm/kcmsrv_ops.c
71e593
@@ -698,9 +698,10 @@ static void kcm_op_destroy_getbyname_done(struct tevent_req *subreq)
71e593
     ret = kcm_ccdb_uuid_by_name_recv(subreq, state, uuid);
71e593
     talloc_zfree(subreq);
71e593
     if (ret != EOK) {
71e593
-        DEBUG(SSSDBG_OP_FAILURE,
71e593
+        DEBUG(SSSDBG_MINOR_FAILURE,
71e593
               "Cannot get matching ccache [%d]: %s\n",
71e593
               ret, sss_strerror(ret));
71e593
+        ret = ERR_NO_MATCHING_CREDS;
71e593
         tevent_req_error(req, ret);
71e593
         return;
71e593
     }
71e593
-- 
71e593
2.19.1
71e593