dcavalca / rpms / systemd

Forked from rpms/systemd 3 months ago
Clone
8f24f2
From f784cdd269ccba28e3e14b24ecd33ab9db148403 Mon Sep 17 00:00:00 2001
8f24f2
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
8f24f2
Date: Wed, 7 Apr 2021 23:24:25 +0200
8f24f2
Subject: [PATCH] tests: make inverted tests actually count
8f24f2
MIME-Version: 1.0
8f24f2
Content-Type: text/plain; charset=UTF-8
8f24f2
Content-Transfer-Encoding: 8bit
8f24f2
8f24f2
"! test ..." does not cause the script to fail, even with set -e.
8f24f2
IIUC, bash treats this command as part of an expression line, as it
8f24f2
would if 'test ... && ...' was used. Failing expression lines do not
8f24f2
terminate the script.
8f24f2
8f24f2
This fixes the obvious cases by changing '! test' → 'test !'.
8f24f2
Then the inversion happens internally in test and bash will propagate
8f24f2
the failure.
8f24f2
8f24f2
(cherry picked from commit ffa328f060f437f3e1f0f0cb13513ee3dd9c3da5)
8f24f2
8f24f2
Related: #2087152
8f24f2
---
8f24f2
 test/TEST-22-TMPFILES/test-01.sh | 2 +-
8f24f2
 1 file changed, 1 insertion(+), 1 deletion(-)
8f24f2
8f24f2
diff --git a/test/TEST-22-TMPFILES/test-01.sh b/test/TEST-22-TMPFILES/test-01.sh
8f24f2
index d233e37fb2..b10b5aaa1a 100755
8f24f2
--- a/test/TEST-22-TMPFILES/test-01.sh
8f24f2
+++ b/test/TEST-22-TMPFILES/test-01.sh
8f24f2
@@ -10,4 +10,4 @@ rm -fr /tmp/test
8f24f2
 
8f24f2
 echo "e /tmp/test - root root 1d" | systemd-tmpfiles --create -
8f24f2
 
8f24f2
-! test -e /tmp/test
8f24f2
+test ! -e /tmp/test