dcavalca / rpms / systemd

Forked from rpms/systemd 3 months ago
Clone
b677e7
From 4dc498258bd0cce1bc8ad2311c5f12de5678e0af Mon Sep 17 00:00:00 2001
b677e7
From: Jan Macku <jamacku@redhat.com>
b677e7
Date: Thu, 27 May 2021 12:25:51 +0200
b677e7
Subject: [PATCH] core: Hide "Deactivated successfully" message
b677e7
b677e7
Show message "Deactivated successfully" in debug mode (when manager is
b677e7
user) rather than in info mode. This message has low information value
b677e7
for regular users and it might be a bit overwhelming on a system with
b677e7
a lot of devices.
b677e7
b677e7
(cherry picked from commit edf2ee22f54005d76b2fb8fdcc9c60974feb88bc)
b677e7
b677e7
Resolves: #1954802
b677e7
---
b677e7
 src/core/unit.c | 5 ++++-
b677e7
 1 file changed, 4 insertions(+), 1 deletion(-)
b677e7
b677e7
diff --git a/src/core/unit.c b/src/core/unit.c
b677e7
index cd3e7c806d..93c13e58d9 100644
b677e7
--- a/src/core/unit.c
b677e7
+++ b/src/core/unit.c
b677e7
@@ -5525,7 +5525,10 @@ int unit_pid_attachable(Unit *u, pid_t pid, sd_bus_error *error) {
b677e7
 void unit_log_success(Unit *u) {
b677e7
         assert(u);
b677e7
 
b677e7
-        log_struct(LOG_INFO,
b677e7
+        /* Let's show message "Deactivated successfully" in debug mode (when manager is user) rather than in info mode.
b677e7
+         * This message has low information value for regular users and it might be a bit overwhelming on a system with
b677e7
+         * a lot of devices. */
b677e7
+        log_struct(MANAGER_IS_USER(u->manager) ? LOG_DEBUG : LOG_INFO,
b677e7
                    "MESSAGE_ID=" SD_MESSAGE_UNIT_SUCCESS_STR,
b677e7
                    LOG_UNIT_ID(u),
b677e7
                    LOG_UNIT_INVOCATION_ID(u),