dcavalca / rpms / mdadm

Forked from rpms/mdadm 3 years ago
Clone

Blame SOURCES/Monitor-don-t-assume-mdadm-parameter-is-a-blockdevi.patch

b7f731
From cb91230c87e02bf885759e9218abea629ab9f4b9 Mon Sep 17 00:00:00 2001
b7f731
From: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
b7f731
Date: Mon, 19 Jun 2017 11:19:53 +0200
b7f731
Subject: [RHEL7.5 PATCH 158/169] Monitor: don't assume mdadm parameter is
b7f731
 a block device
b7f731
b7f731
If symlink (e.g. /dev/md/raid) is passed as a parameter to mdadm --wait,
b7f731
it fails as it's not able to find a corresponding entry in /proc/mdstat
b7f731
output. Get parameter file major:minor and look for block device name in
b7f731
sysfs. This commit is partial revert of commit 9e04ac1c43e6
b7f731
("mdadm/util: unify stat checking blkdev into function").
b7f731
b7f731
Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
b7f731
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
b7f731
---
b7f731
 Monitor.c | 13 +++++++++++--
b7f731
 1 file changed, 11 insertions(+), 2 deletions(-)
b7f731
b7f731
diff --git a/Monitor.c b/Monitor.c
b7f731
index bef2f1b..48c451c 100644
b7f731
--- a/Monitor.c
b7f731
+++ b/Monitor.c
b7f731
@@ -982,12 +982,21 @@ static void link_containers_with_subarrays(struct state *list)
b7f731
 int Wait(char *dev)
b7f731
 {
b7f731
 	char devnm[32];
b7f731
+	dev_t rdev;
b7f731
+	char *tmp;
b7f731
 	int rv = 1;
b7f731
 	int frozen_remaining = 3;
b7f731
 
b7f731
-	if (!stat_is_blkdev(dev, NULL))
b7f731
+	if (!stat_is_blkdev(dev, &rdev))
b7f731
+		return 2;
b7f731
+
b7f731
+	tmp = devid2devnm(rdev);
b7f731
+	if (!tmp) {
b7f731
+		pr_err("Cannot get md device name.\n");
b7f731
 		return 2;
b7f731
-	strcpy(devnm, dev);
b7f731
+	}
b7f731
+
b7f731
+	strcpy(devnm, tmp);
b7f731
 
b7f731
 	while(1) {
b7f731
 		struct mdstat_ent *ms = mdstat_read(1, 0);
b7f731
-- 
b7f731
2.7.4
b7f731