dcavalca / rpms / mdadm

Forked from rpms/mdadm 3 years ago
Clone

Blame SOURCES/0024-mdadm-test-mdadm-needn-t-make-install-on-the-system.patch

d922d5
From 38e955cbf030bc9e564bd87bc9f02f949884a83f Mon Sep 17 00:00:00 2001
d922d5
From: Zhilong Liu <zlliu@suse.com>
d922d5
Date: Wed, 30 May 2018 15:04:05 +0800
d922d5
Subject: [RHEL7.5 PATCH 24/26] mdadm/test: mdadm needn't make install on the
d922d5
 system
d922d5
d922d5
Fixes: beb71de04d31 ("mdadm/test: enable clustermd testing under clustermd_tests/")
d922d5
clustermd_tests/func.sh:
d922d5
remove unnecessary 'make install', just ensure 'make everything' has done.
d922d5
the original idea is to make the /sbin/mdadm version same as ./mdadm, and
d922d5
this breakage has pointed out by commit:
d922d5
59416da78fc6 ("tests/func.sh: Fix some total breakage in the test scripts")
d922d5
d922d5
Signed-off-by: Zhilong Liu <zlliu@suse.com>
d922d5
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
d922d5
---
d922d5
 clustermd_tests/func.sh | 11 ++++-------
d922d5
 1 file changed, 4 insertions(+), 7 deletions(-)
d922d5
d922d5
diff --git a/clustermd_tests/func.sh b/clustermd_tests/func.sh
d922d5
index c2be0e5..642cc96 100644
d922d5
--- a/clustermd_tests/func.sh
d922d5
+++ b/clustermd_tests/func.sh
d922d5
@@ -86,10 +86,13 @@ check_env()
d922d5
 		echo "testing can only be done as 'root'."
d922d5
 		exit 1
d922d5
 	}
d922d5
+	[ \! -x $mdadm ] && {
d922d5
+		echo "test: please run make everything before perform testing."
d922d5
+		exit 1
d922d5
+	}
d922d5
 	check_ssh
d922d5
 	commands=(mdadm iscsiadm bc modinfo dlm_controld
d922d5
 		  udevadm crm crm_mon lsblk pgrep sbd)
d922d5
-	mdadm_src_ver="$($mdadm -V 2>&1)"
d922d5
 	for ip in $NODE1 $NODE2
d922d5
 	do
d922d5
 		for cmd in ${commands[@]}
d922d5
@@ -99,12 +102,6 @@ check_env()
d922d5
 				exit 1
d922d5
 			}
d922d5
 		done
d922d5
-		mdadm_sbin_ver="$(ssh $ip "mdadm -V 2>&1")"
d922d5
-		if [ "$mdadm_src_ver" != "$mdadm_sbin_ver" ]
d922d5
-		then
d922d5
-			echo "$ip: please run 'make install' before testing."
d922d5
-			exit 1
d922d5
-		fi
d922d5
 		mods=(raid1 raid10 md_mod dlm md-cluster)
d922d5
 		for mod in ${mods[@]}
d922d5
 		do
d922d5
-- 
d922d5
2.7.4
d922d5