dcavalca / rpms / grub2

Forked from rpms/grub2 3 years ago
Clone

Blame SOURCES/0161-Revert-efinet-memory-leak-on-module-removal.patch

4fe85b
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
4fe85b
From: Andrei Borzenkov <arvidjaar@gmail.com>
4fe85b
Date: Mon, 4 May 2015 09:13:53 +0300
4fe85b
Subject: [PATCH] Revert "efinet: memory leak on module removal"
4fe85b
4fe85b
This reverts commits 47b2bee3ef0ea60fc3f5bfc37f3784e559385297
4fe85b
and 8d3c4544ffdd0289a4b0bdeb0cdc6355f801a4b3. It is not safe
4fe85b
to free allocated cards, dangling pointers main remain. Such
4fe85b
cleanup requires more changes in net core.
4fe85b
---
4fe85b
 grub-core/net/drivers/efi/efinet.c | 8 +-------
4fe85b
 1 file changed, 1 insertion(+), 7 deletions(-)
4fe85b
4fe85b
diff --git a/grub-core/net/drivers/efi/efinet.c b/grub-core/net/drivers/efi/efinet.c
4fe85b
index bb863e65a38..78df215be12 100644
4fe85b
--- a/grub-core/net/drivers/efi/efinet.c
4fe85b
+++ b/grub-core/net/drivers/efi/efinet.c
4fe85b
@@ -294,12 +294,6 @@ GRUB_MOD_FINI(efinet)
4fe85b
 
4fe85b
   FOR_NET_CARDS_SAFE (card, next) 
4fe85b
     if (card->driver == &efidriver)
4fe85b
-      {
4fe85b
-	grub_net_card_unregister (card);
4fe85b
-	grub_free (card->txbuf);
4fe85b
-	grub_free (card->rcvbuf);
4fe85b
-	grub_free ((char *)card->name);
4fe85b
-	grub_free (card);
4fe85b
-      }
4fe85b
+      grub_net_card_unregister (card);
4fe85b
 }
4fe85b