dcavalca / rpms / grub2

Forked from rpms/grub2 3 years ago
Clone

Blame SOURCES/0161-Revert-efinet-memory-leak-on-module-removal.patch

f725e3
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
f725e3
From: Andrei Borzenkov <arvidjaar@gmail.com>
f725e3
Date: Mon, 4 May 2015 09:13:53 +0300
f725e3
Subject: [PATCH] Revert "efinet: memory leak on module removal"
f725e3
f725e3
This reverts commits 47b2bee3ef0ea60fc3f5bfc37f3784e559385297
f725e3
and 8d3c4544ffdd0289a4b0bdeb0cdc6355f801a4b3. It is not safe
f725e3
to free allocated cards, dangling pointers main remain. Such
f725e3
cleanup requires more changes in net core.
f725e3
---
f725e3
 grub-core/net/drivers/efi/efinet.c | 8 +-------
f725e3
 1 file changed, 1 insertion(+), 7 deletions(-)
f725e3
f725e3
diff --git a/grub-core/net/drivers/efi/efinet.c b/grub-core/net/drivers/efi/efinet.c
f725e3
index bb863e65a38..78df215be12 100644
f725e3
--- a/grub-core/net/drivers/efi/efinet.c
f725e3
+++ b/grub-core/net/drivers/efi/efinet.c
f725e3
@@ -294,12 +294,6 @@ GRUB_MOD_FINI(efinet)
f725e3
 
f725e3
   FOR_NET_CARDS_SAFE (card, next) 
f725e3
     if (card->driver == &efidriver)
f725e3
-      {
f725e3
-	grub_net_card_unregister (card);
f725e3
-	grub_free (card->txbuf);
f725e3
-	grub_free (card->rcvbuf);
f725e3
-	grub_free ((char *)card->name);
f725e3
-	grub_free (card);
f725e3
-      }
f725e3
+      grub_net_card_unregister (card);
f725e3
 }
f725e3