|
 |
9ae3a8 |
From 225cb3d48dd4dcbc7bf845c0b4b06a90030874f3 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Date: Wed, 27 Jul 2016 07:35:06 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 08/16] qjson: Inline token_is_escape() and simplify
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1469604913-12442-10-git-send-email-armbru@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 71479
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.3 qemu-kvm PATCH v2 08/15] qjson: Inline token_is_escape() and simplify
|
|
|
9ae3a8 |
Bugzilla: 1276036
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Message-Id: <1448486613-17634-8-git-send-email-armbru@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
9ae3a8 |
(cherry picked from commit 6b9606f68ec589def27bd2a9cea97ec63cffd581)
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Conflicts:
|
|
|
9ae3a8 |
qobject/json-parser.c
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Straighforward conflict because lacking commit fc48ffc "qobject: Use
|
|
|
9ae3a8 |
'bool' for qbool", we still use qbool_from_int().
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
qobject/json-parser.c | 32 +++++++++++++++-----------------
|
|
|
9ae3a8 |
1 file changed, 15 insertions(+), 17 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/qobject/json-parser.c b/qobject/json-parser.c
|
|
|
9ae3a8 |
index e3690de..79f4173 100644
|
|
|
9ae3a8 |
--- a/qobject/json-parser.c
|
|
|
9ae3a8 |
+++ b/qobject/json-parser.c
|
|
|
9ae3a8 |
@@ -64,15 +64,6 @@ static JSONTokenType token_get_type(QObject *obj)
|
|
|
9ae3a8 |
return qdict_get_int(qobject_to_qdict(obj), "type");
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
-static int token_is_escape(QObject *obj, const char *value)
|
|
|
9ae3a8 |
-{
|
|
|
9ae3a8 |
- if (token_get_type(obj) != JSON_ESCAPE) {
|
|
|
9ae3a8 |
- return 0;
|
|
|
9ae3a8 |
- }
|
|
|
9ae3a8 |
-
|
|
|
9ae3a8 |
- return (strcmp(token_get_value(obj), value) == 0);
|
|
|
9ae3a8 |
-}
|
|
|
9ae3a8 |
-
|
|
|
9ae3a8 |
/**
|
|
|
9ae3a8 |
* Error handler
|
|
|
9ae3a8 |
*/
|
|
|
9ae3a8 |
@@ -559,6 +550,7 @@ static QObject *parse_escape(JSONParserContext *ctxt, va_list *ap)
|
|
|
9ae3a8 |
{
|
|
|
9ae3a8 |
QObject *token = NULL, *obj;
|
|
|
9ae3a8 |
JSONParserContext saved_ctxt = parser_context_save(ctxt);
|
|
|
9ae3a8 |
+ const char *val;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
if (ap == NULL) {
|
|
|
9ae3a8 |
goto out;
|
|
|
9ae3a8 |
@@ -569,20 +561,26 @@ static QObject *parse_escape(JSONParserContext *ctxt, va_list *ap)
|
|
|
9ae3a8 |
goto out;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- if (token_is_escape(token, "%p")) {
|
|
|
9ae3a8 |
+ if (token_get_type(token) != JSON_ESCAPE) {
|
|
|
9ae3a8 |
+ goto out;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+
|
|
|
9ae3a8 |
+ val = token_get_value(token);
|
|
|
9ae3a8 |
+
|
|
|
9ae3a8 |
+ if (!strcmp(val, "%p")) {
|
|
|
9ae3a8 |
obj = va_arg(*ap, QObject *);
|
|
|
9ae3a8 |
- } else if (token_is_escape(token, "%i")) {
|
|
|
9ae3a8 |
+ } else if (!strcmp(val, "%i")) {
|
|
|
9ae3a8 |
obj = QOBJECT(qbool_from_int(va_arg(*ap, int)));
|
|
|
9ae3a8 |
- } else if (token_is_escape(token, "%d")) {
|
|
|
9ae3a8 |
+ } else if (!strcmp(val, "%d")) {
|
|
|
9ae3a8 |
obj = QOBJECT(qint_from_int(va_arg(*ap, int)));
|
|
|
9ae3a8 |
- } else if (token_is_escape(token, "%ld")) {
|
|
|
9ae3a8 |
+ } else if (!strcmp(val, "%ld")) {
|
|
|
9ae3a8 |
obj = QOBJECT(qint_from_int(va_arg(*ap, long)));
|
|
|
9ae3a8 |
- } else if (token_is_escape(token, "%lld") ||
|
|
|
9ae3a8 |
- token_is_escape(token, "%I64d")) {
|
|
|
9ae3a8 |
+ } else if (!strcmp(val, "%lld") ||
|
|
|
9ae3a8 |
+ !strcmp(val, "%I64d")) {
|
|
|
9ae3a8 |
obj = QOBJECT(qint_from_int(va_arg(*ap, long long)));
|
|
|
9ae3a8 |
- } else if (token_is_escape(token, "%s")) {
|
|
|
9ae3a8 |
+ } else if (!strcmp(val, "%s")) {
|
|
|
9ae3a8 |
obj = QOBJECT(qstring_from_str(va_arg(*ap, const char *)));
|
|
|
9ae3a8 |
- } else if (token_is_escape(token, "%f")) {
|
|
|
9ae3a8 |
+ } else if (!strcmp(val, "%f")) {
|
|
|
9ae3a8 |
obj = QOBJECT(qfloat_from_double(va_arg(*ap, double)));
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
goto out;
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|