|
 |
87ca29 |
From a80ba745cc54d5ba726e48065aebe6dac50dedd2 Mon Sep 17 00:00:00 2001
|
|
|
87ca29 |
From: Karel Zak <kzak@redhat.com>
|
|
|
87ca29 |
Date: Mon, 24 Jan 2022 14:08:08 +0100
|
|
|
87ca29 |
Subject: uuidd: fix open/lock state issue
|
|
|
87ca29 |
|
|
|
87ca29 |
* warn on open/lock state issue
|
|
|
87ca29 |
|
|
|
87ca29 |
* enable access to /var/lib/libuuid/, because ProtectSystem=strict make it read-only
|
|
|
87ca29 |
|
|
|
87ca29 |
openat(AT_FDCWD, "/var/lib/libuuid/clock.txt",
|
|
|
87ca29 |
O_RDWR|O_CREAT|O_CLOEXEC, 0660) = -1 EROFS (Read-only file system)
|
|
|
87ca29 |
|
|
|
87ca29 |
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2040366
|
|
|
87ca29 |
Upstream: http://github.com/util-linux/util-linux/commit/f27876f9c1056bf41fd940d5c4990b4277e0024f
|
|
|
87ca29 |
Upstream: http://github.com/util-linux/util-linux/commit/417982d0236a12756923d88e627f5e4facf8951c
|
|
|
87ca29 |
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
87ca29 |
---
|
|
|
87ca29 |
misc-utils/uuidd.c | 9 ++++++---
|
|
|
87ca29 |
misc-utils/uuidd.service.in | 1 +
|
|
|
87ca29 |
2 files changed, 7 insertions(+), 3 deletions(-)
|
|
|
87ca29 |
|
|
|
87ca29 |
diff --git a/misc-utils/uuidd.c b/misc-utils/uuidd.c
|
|
|
87ca29 |
index fa8db173b..78a37d2e8 100644
|
|
|
87ca29 |
--- a/misc-utils/uuidd.c
|
|
|
87ca29 |
+++ b/misc-utils/uuidd.c
|
|
|
87ca29 |
@@ -494,7 +494,8 @@ static void server_loop(const char *socket_path, const char *pidfile_path,
|
|
|
87ca29 |
break;
|
|
|
87ca29 |
case UUIDD_OP_TIME_UUID:
|
|
|
87ca29 |
num = 1;
|
|
|
87ca29 |
- __uuid_generate_time(uu, &num);
|
|
|
87ca29 |
+ if (__uuid_generate_time(uu, &num) < 0 && !uuidd_cxt->quiet)
|
|
|
87ca29 |
+ warnx(_("failed to open/lock clock counter"));
|
|
|
87ca29 |
if (uuidd_cxt->debug) {
|
|
|
87ca29 |
uuid_unparse(uu, str);
|
|
|
87ca29 |
fprintf(stderr, _("Generated time UUID: %s\n"), str);
|
|
|
87ca29 |
@@ -504,7 +505,8 @@ static void server_loop(const char *socket_path, const char *pidfile_path,
|
|
|
87ca29 |
break;
|
|
|
87ca29 |
case UUIDD_OP_RANDOM_UUID:
|
|
|
87ca29 |
num = 1;
|
|
|
87ca29 |
- __uuid_generate_random(uu, &num);
|
|
|
87ca29 |
+ if (__uuid_generate_time(uu, &num) < 0 && !uuidd_cxt->quiet)
|
|
|
87ca29 |
+ warnx(_("failed to open/lock clock counter"));
|
|
|
87ca29 |
if (uuidd_cxt->debug) {
|
|
|
87ca29 |
uuid_unparse(uu, str);
|
|
|
87ca29 |
fprintf(stderr, _("Generated random UUID: %s\n"), str);
|
|
|
87ca29 |
@@ -513,7 +515,8 @@ static void server_loop(const char *socket_path, const char *pidfile_path,
|
|
|
87ca29 |
reply_len = sizeof(uu);
|
|
|
87ca29 |
break;
|
|
|
87ca29 |
case UUIDD_OP_BULK_TIME_UUID:
|
|
|
87ca29 |
- __uuid_generate_time(uu, &num);
|
|
|
87ca29 |
+ if (__uuid_generate_time(uu, &num) < 0 && !uuidd_cxt->quiet)
|
|
|
87ca29 |
+ warnx(_("failed to open/lock clock counter"));
|
|
|
87ca29 |
if (uuidd_cxt->debug) {
|
|
|
87ca29 |
uuid_unparse(uu, str);
|
|
|
87ca29 |
fprintf(stderr, P_("Generated time UUID %s "
|
|
|
87ca29 |
diff --git a/misc-utils/uuidd.service.in b/misc-utils/uuidd.service.in
|
|
|
87ca29 |
index b4c9c4635..e64ca59b5 100644
|
|
|
87ca29 |
--- a/misc-utils/uuidd.service.in
|
|
|
87ca29 |
+++ b/misc-utils/uuidd.service.in
|
|
|
87ca29 |
@@ -18,6 +18,7 @@ ProtectKernelModules=yes
|
|
|
87ca29 |
ProtectControlGroups=yes
|
|
|
87ca29 |
RestrictAddressFamilies=AF_UNIX
|
|
|
87ca29 |
MemoryDenyWriteExecute=yes
|
|
|
87ca29 |
+ReadWritePaths=/var/lib/libuuid/
|
|
|
87ca29 |
SystemCallFilter=@default @file-system @basic-io @system-service @signal @io-event @network-io
|
|
|
87ca29 |
|
|
|
87ca29 |
[Install]
|
|
|
87ca29 |
--
|
|
|
87ca29 |
2.34.1
|
|
|
87ca29 |
|