|
 |
47a954 |
From 64315aad40a4a525611c2d66cff1c214c29ed44a Mon Sep 17 00:00:00 2001
|
|
|
47a954 |
From: Martin Pitt <martinpitt@users.noreply.github.com>
|
|
|
47a954 |
Date: Mon, 26 Feb 2018 08:55:27 +0100
|
|
|
47a954 |
Subject: [PATCH] storaged: Drop VDO async option (#8679)
|
|
|
47a954 |
|
|
|
47a954 |
The current VDO version will auto detect the correct setting to use for
|
|
|
47a954 |
write policy (either sync or async). Explicitly setting the option
|
|
|
47a954 |
disable the auto feature and set VDO to async mode, which may get
|
|
|
47a954 |
into an unsupported configuration later on.
|
|
|
47a954 |
|
|
|
47a954 |
As this is also an option that is quite hard to explain to users and we
|
|
|
47a954 |
don't/can't give them the information that they need to do an informed
|
|
|
47a954 |
decision, just remove the option completely and rely on automatic
|
|
|
47a954 |
detection.
|
|
|
47a954 |
---
|
|
|
47a954 |
pkg/storaged/client.js | 2 --
|
|
|
47a954 |
pkg/storaged/vdos-panel.jsx | 5 -----
|
|
|
47a954 |
2 files changed, 7 deletions(-)
|
|
|
47a954 |
|
|
|
47a954 |
diff --git a/pkg/storaged/client.js b/pkg/storaged/client.js
|
|
|
47a954 |
index 54f7e4e..761605c 100644
|
|
|
47a954 |
--- a/pkg/storaged/client.js
|
|
|
47a954 |
+++ b/pkg/storaged/client.js
|
|
|
47a954 |
@@ -695,8 +695,6 @@
|
|
|
47a954 |
args.push("--deduplication", options.deduplication? "enabled" : "disabled");
|
|
|
47a954 |
if (options.emulate_512 !== undefined)
|
|
|
47a954 |
args.push("--emulate512", options.emulate_512? "enabled" : "disabled");
|
|
|
47a954 |
- if (options.asynchronous !== undefined)
|
|
|
47a954 |
- args.push("--writePolicy", options.asynchronous? "async" : "sync");
|
|
|
47a954 |
return cmd(args);
|
|
|
47a954 |
}
|
|
|
47a954 |
|
|
|
47a954 |
diff --git a/pkg/storaged/vdos-panel.jsx b/pkg/storaged/vdos-panel.jsx
|
|
|
47a954 |
index 035760d..529b08f 100644
|
|
|
47a954 |
--- a/pkg/storaged/vdos-panel.jsx
|
|
|
47a954 |
+++ b/pkg/storaged/vdos-panel.jsx
|
|
|
47a954 |
@@ -98,10 +98,6 @@ export class VDOsPanel extends React.Component {
|
|
|
47a954 |
Title: _("Deduplication"),
|
|
|
47a954 |
Value: true
|
|
|
47a954 |
},
|
|
|
47a954 |
- { CheckBox: "asynchronous",
|
|
|
47a954 |
- Title: _("Transfer data asynchronously"),
|
|
|
47a954 |
- Value: false,
|
|
|
47a954 |
- },
|
|
|
47a954 |
{ CheckBox: "emulate_512",
|
|
|
47a954 |
Title: _("Use 512 Byte emulation"),
|
|
|
47a954 |
Value: false
|
|
|
47a954 |
@@ -124,7 +120,6 @@ export class VDOsPanel extends React.Component {
|
|
|
47a954 |
index_mem: vals.index_mem,
|
|
|
47a954 |
compression: vals.compression,
|
|
|
47a954 |
deduplication: vals.deduplication,
|
|
|
47a954 |
- asynchronous: vals.asynchronous,
|
|
|
47a954 |
emulate_512: vals.emulate_512
|
|
|
47a954 |
});
|
|
|
47a954 |
});
|
|
|
47a954 |
--
|
|
|
47a954 |
2.14.3
|
|
|
47a954 |
|