anitazha / rpms / ndctl

Forked from rpms/ndctl 2 years ago
Clone

Blame 0144-libdaxctl-free-resource-allocated-with-asprintf.patch

Jeff Moyer 2c91dc
From 057ca6fc2ce63625236bf00e795e0847e6508ed8 Mon Sep 17 00:00:00 2001
Jeff Moyer 2c91dc
From: Alison Schofield <alison.schofield@intel.com>
Jeff Moyer 2c91dc
Date: Thu, 3 Mar 2022 16:01:33 -0800
Jeff Moyer 2c91dc
Subject: [PATCH 144/217] libdaxctl: free resource allocated with asprintf()
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
Static analysis reported this resource leak.
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
Link: https://lore.kernel.org/r/20220304000133.1053883-1-alison.schofield@intel.com
Jeff Moyer 2c91dc
Fixes: d07508a0cc3c ("libdaxctl: add daxctl_region_create_dev()")
Jeff Moyer 2c91dc
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Jeff Moyer 2c91dc
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Jeff Moyer 2c91dc
---
Jeff Moyer 2c91dc
 daxctl/lib/libdaxctl.c | 5 ++---
Jeff Moyer 2c91dc
 1 file changed, 2 insertions(+), 3 deletions(-)
Jeff Moyer 2c91dc
Jeff Moyer 2c91dc
diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
Jeff Moyer 2c91dc
index f173bbb..5703992 100644
Jeff Moyer 2c91dc
--- a/daxctl/lib/libdaxctl.c
Jeff Moyer 2c91dc
+++ b/daxctl/lib/libdaxctl.c
Jeff Moyer 2c91dc
@@ -624,10 +624,9 @@ DAXCTL_EXPORT int daxctl_region_create_dev(struct daxctl_region *region)
Jeff Moyer 2c91dc
 	}
Jeff Moyer 2c91dc
 
Jeff Moyer 2c91dc
 	rc = sysfs_write_attr(ctx, path, num_devices);
Jeff Moyer 2c91dc
-	if (rc)
Jeff Moyer 2c91dc
-		return rc;
Jeff Moyer 2c91dc
+	free(num_devices);
Jeff Moyer 2c91dc
 
Jeff Moyer 2c91dc
-	return 0;
Jeff Moyer 2c91dc
+	return rc;
Jeff Moyer 2c91dc
 }
Jeff Moyer 2c91dc
 
Jeff Moyer 2c91dc
 DAXCTL_EXPORT int daxctl_region_destroy_dev(struct daxctl_region *region,
Jeff Moyer 2c91dc
-- 
Jeff Moyer 2c91dc
2.27.0
Jeff Moyer 2c91dc