andykimpe / rpms / 389-ds-base

Forked from rpms/389-ds-base 5 months ago
Clone

Blame 0314-Ticket-48154-abort-cleanAllRUV-tasks-should-not-cert.patch

dc8c34
From 5fcd385572ccf2d4a3c3030723617eaec8ae1516 Mon Sep 17 00:00:00 2001
dc8c34
From: Mark Reynolds <mreynolds@redhat.com>
dc8c34
Date: Tue, 21 Apr 2015 12:23:47 -0400
dc8c34
Subject: [PATCH 314/319] Ticket 48154 - abort cleanAllRUV tasks should not
dc8c34
 certify-all by default
dc8c34
dc8c34
Bug Description:  The current default for an abort task is to certify that
dc8c34
                  all the replicas receive and process the abort task.  The
dc8c34
                  problem is that if we are trying to abort a cleanallruv
dc8c34
                  task because it is "hanging" due to some replicas not
dc8c34
                  being reachable, the abort task will also "hang".
dc8c34
dc8c34
Fix Description:  The default for certify-all should be "no".
dc8c34
dc8c34
https://fedorahosted.org/389/ticket/48154
dc8c34
dc8c34
Reviewed by: nhosoi(Thanks!)
dc8c34
dc8c34
(cherry picked from commit 465e1059493a8dacf3caf7776824e8149e878b93)
dc8c34
(cherry picked from commit ba488271c51a0bd566a4f728709ff959d64a0ed3)
dc8c34
---
dc8c34
 ldap/servers/plugins/replication/repl5_replica_config.c | 8 +++++++-
dc8c34
 1 file changed, 7 insertions(+), 1 deletion(-)
dc8c34
dc8c34
diff --git a/ldap/servers/plugins/replication/repl5_replica_config.c b/ldap/servers/plugins/replication/repl5_replica_config.c
dc8c34
index 94ab71b..daefc03 100644
dc8c34
--- a/ldap/servers/plugins/replication/repl5_replica_config.c
dc8c34
+++ b/ldap/servers/plugins/replication/repl5_replica_config.c
dc8c34
@@ -2596,7 +2596,13 @@ replica_cleanall_ruv_abort(Slapi_PBlock *pb, Slapi_Entry *e, Slapi_Entry *eAfter
dc8c34
             goto out;
dc8c34
         }
dc8c34
     } else {
dc8c34
-        certify_all = "yes";
dc8c34
+        /*
dc8c34
+         * The default should be not to certify all the replicas, because
dc8c34
+         * we might be trying to abort a clean task that is "hanging" due
dc8c34
+         * to unreachable replicas.  If the default is "yes" then the abort
dc8c34
+         * task will run into the same issue.
dc8c34
+         */
dc8c34
+        certify_all = "no";
dc8c34
     }
dc8c34
     /*
dc8c34
      *  Create payload
dc8c34
-- 
dc8c34
1.9.3
dc8c34