andykimpe / rpms / 389-ds-base

Forked from rpms/389-ds-base 9 months ago
Clone
dc8c34
From be33e3181d13b8363a8a5e0de3c860a03cc61e58 Mon Sep 17 00:00:00 2001
dc8c34
From: Mark Reynolds <mreynolds@redhat.com>
dc8c34
Date: Sat, 14 Dec 2013 07:38:12 -0500
dc8c34
Subject: [PATCH 153/225] Ticket 47627 - Fix replication logging
dc8c34
dc8c34
We printed the same CSN for the missing CSN and the supplier min CSN because
dc8c34
we reused the same CSN pointer.
dc8c34
dc8c34
https://fedorahosted.org/389/ticket/47627
dc8c34
dc8c34
Reviewed by: rmeggins(Thanks!)
dc8c34
(cherry picked from commit 20cccf58108099cead2412a979e70e4f5972b806)
dc8c34
(cherry picked from commit 962de25824635ff66ab0dd95dacdca17a38d147a)
dc8c34
---
dc8c34
 ldap/servers/plugins/replication/cl5_api.c | 13 +++++++++----
dc8c34
 1 file changed, 9 insertions(+), 4 deletions(-)
dc8c34
dc8c34
diff --git a/ldap/servers/plugins/replication/cl5_api.c b/ldap/servers/plugins/replication/cl5_api.c
dc8c34
index 55bda39..ae522a3 100644
dc8c34
--- a/ldap/servers/plugins/replication/cl5_api.c
dc8c34
+++ b/ldap/servers/plugins/replication/cl5_api.c
dc8c34
@@ -5041,6 +5041,7 @@ static int _cl5PositionCursorForReplay (ReplicaId consumerRID, const RUV *consum
dc8c34
     int i;
dc8c34
     CSN **csns = NULL;
dc8c34
     CSN *startCSN = NULL;
dc8c34
+    CSN *minCSN = NULL;
dc8c34
     char csnStr [CSN_STRSIZE];
dc8c34
     int rc = CL5_SUCCESS;
dc8c34
     Object *supplierRuvObj = NULL;
dc8c34
@@ -5130,20 +5131,24 @@ static int _cl5PositionCursorForReplay (ReplicaId consumerRID, const RUV *consum
dc8c34
 		*/
dc8c34
         if ((rc == DB_NOTFOUND) && !ruv_has_csns(file->purgeRUV))
dc8c34
         {
dc8c34
+            char mincsnStr[CSN_STRSIZE];
dc8c34
+
dc8c34
             /* use the supplier min csn for the buffer start csn - we know
dc8c34
                this csn is in our changelog */
dc8c34
-            if ((RUV_SUCCESS == ruv_get_min_csn_ext(supplierRuv, &startCSN, 1 /* ignore cleaned rids */)) &&
dc8c34
-                startCSN)
dc8c34
+            if ((RUV_SUCCESS == ruv_get_min_csn_ext(supplierRuv, &minCSN, 1 /* ignore cleaned rids */)) &&
dc8c34
+                minCSN)
dc8c34
             { /* must now free startCSN */
dc8c34
                 if (slapi_is_loglevel_set(SLAPI_LOG_REPL)) {
dc8c34
-                    csn_as_string(startCSN, PR_FALSE, csnStr); 
dc8c34
+                    csn_as_string(startCSN, PR_FALSE, csnStr);
dc8c34
+                    csn_as_string(minCSN, PR_FALSE, mincsnStr);
dc8c34
                     slapi_log_error(SLAPI_LOG_REPL, repl_plugin_name_cl, 
dc8c34
                                     "%s: CSN %s not found and no purging, probably a reinit\n",
dc8c34
                                     agmt_name, csnStr);
dc8c34
                     slapi_log_error(SLAPI_LOG_REPL, repl_plugin_name_cl, 
dc8c34
                                     "%s: Will try to use supplier min CSN %s to load changelog\n",
dc8c34
-                                    agmt_name, csnStr);
dc8c34
+                                    agmt_name, mincsnStr);
dc8c34
                 }
dc8c34
+                startCSN = minCSN;
dc8c34
                 rc = clcache_load_buffer (clcache, startCSN, DB_SET);
dc8c34
             }
dc8c34
             else
dc8c34
-- 
dc8c34
1.8.1.4
dc8c34