PR#104: Set stabilization if any branch is in stabilization (CS-2523) - centos/centpkg

centos / centpkg

#104 Set stabilization if any branch is in stabilization (CS-2523)

Merged 2 months ago by tdawson. Opened 2 months ago by tdawson.

centos/ tdawson/centpkg fix-stabilization into develop

Set stabilization if any branch is in stabilization (CS-2523)

Troy Dawson • 2 months ago

7dbbdb

src/centpkg/utils.py

file modified

+3 -1

		`@@ -399,6 +399,7 @@`

		`active_y_version = -1`
		`beta = False`
		`+ in_exception_phase = False`
		`for entry in payload:`
		`shortname = entry["shortname"]`

		`@@ -410,7 +411,8 @@`
		`active_y_version = y_version`
		`beta = bool(extra_version and "beta" in extra_version)`

		`- in_exception_phase = entry["phase"] == 450`
		`+ if not in_exception_phase:`
		`+ in_exception_phase = entry["phase"] == 450`

		`logger.debug(`
		`"Active Y-stream: {}, Enforcing: {}, Beta: {}".format(`

tdawson commented 2 months ago

Signed-off-by: Troy Dawson tdawson@redhat.com

sgallagh commented 2 months ago

I don't think that's what we want here. We only care about being in stabilization phase for the target.

Put another way; if the rhel-9.5.0 branch exists for the package in RHEL dist-git, we know that CentOS Stream is working on 9.6, which we know is not in Stabilization Phase. But if rhel-9.5.0 does NOT exist AND 9.5 is in Stabilization mode, we need to force the use of --rhel-target.

Of course, the simplest option is to just always require --rhel-target in every case. This might be rough on maintainers though.

tdawson commented 2 months ago

Closing this. This is not the correct way to fix the problem.

Pull-Request has been merged by tdawson

2 months ago