For some days now, the "sponsors" section/block on frontpage on www.centos.org is missing and was wondering why. So creating this issue here to track it with @areguera as it seems it disappeared with his last pushed commit : https://git.centos.org/centos/centos.org/c/92cce89256888b2ca6542bf909f522d8006b43bd?branch=main Can that be reverted and investigated (if that commit was supposed to fix something else) ? I wouldn't want to see more sponsors leaving because of this (and some are really looking after this)
@arrfab thanks for creating the ticket. I already opened https://git.centos.org/centos/centos.org/pull-request/199 to revert the footer.html and expose the former issue.
@arrfab we need to apply the following patch on main branch:
main
The staging branch is not synced with main at the moment to create a MR from it. I'll do that when reach home, in about a couple of hours. Appreciate if someone can do it sooner. Thanks!
staging
Removed the _includes/footer.html and expose the root cause:
_includes/footer.html
<img alt="Screenshot_from_2023-05-02_16-50-36.png" src="/centos/centos.org/issue/raw/files/cbc0b1eb90112643038606941eec95cb4bd194fe4c03817a6814b674846d19a3-Screenshot_from_2023-05-02_16-50-36.png" />
When you click the source definition, it is possible to see the sponsor class being disabled in the very first lines. Note there are much more there:
sponsor
<img alt="css-definition.txt" src="/centos/centos.org/issue/raw/files/423fb00ff23ea5bc363dbf2abdc713d0b27d7a9a2603a2a25411ec702a73b3e7-css-definition.txt" />
Where does this come from? It looks to be Firefox uBlock Origin plugin doesn't like the sponsor class (unexpected change). When uBlock is active, the sponsors section is disabled and, when uBlock is disabled the sponsor section appears. I am taking note of this to change that name to something else because many users using uBlock Origin may be facing this situation. The same happens on chrome when you use Adblock plugin.
uBlock Origin plugin
Please confirm.
As conclusion, the footer.html section shouldn't be replaced in first place. I am sorry about that. It was a wrong assumption from my side. The section has been restored, and action will be taken to change the class name to something else, and so, grant maximum visibility to sponsors on browsers with uBlock Origin plugin active.
footer.html
I confirm what you found. Strangely uBlock doesn't show anything being blocked (0 request blocked)
Hi,
Here is a work in progress to fix this issue:
<img alt="Screenshot_from_2023-07-20_06-52-00.png" src="/centos/centos.org/issue/raw/files/30c0c527a4311c50cb9ef5f5794c0f0a57af8cd73c8c4c3b7c4dfbb0b14e03dd-Screenshot_from_2023-07-20_06-52-00.png" />
A live example for testing this fix is available at https://centos.gitlab.io/artwork/centos-web/jekyll-theme-centos-sponsors/includes/carousel/
The fix is part of the ongoing website redesign effort. The development related to sponsors component is happening openly at https://gitlab.com/CentOS/artwork/centos-web/jekyll-theme-centos-sponsors. Comments and suggestions are welcome.
Thanks.
thanks for the hard work @areguera .. Got sponsor reaching out recently to ask why sponsor section was removed from front page and so revisiting that issue to see when it can be fixed so that I can give them a kind of ETA (but /sponsors link is still working though)
I wish to give a date but I do not have an exact one, yet. I need to redesign the homepage layout first, to accommodate what we have there. I would like to have it ready for this year.
Log in to comment on this ticket.