From 95615a8c32349d25832163114dd29619dadfa614 Mon Sep 17 00:00:00 2001 From: Alain Reguera Delgado Date: Dec 20 2013 16:49:31 +0000 Subject: Remove variable names tuneup from tuneup module. - Previously, tuneup changed variables written in lowercase to their respective name in uppercase inside automation scripts source files. This feature doesn't make much sense if you write correctly from the beginning. This update removes the variable names tuneup from tuneup module in the sake of writing code well from the beginning. --- diff --git a/tcar-scripts-tuneup/Modules/Sh/sh.sh b/tcar-scripts-tuneup/Modules/Sh/sh.sh index 27ef589..b9b4c2d 100755 --- a/tcar-scripts-tuneup/Modules/Sh/sh.sh +++ b/tcar-scripts-tuneup/Modules/Sh/sh.sh @@ -27,6 +27,5 @@ function sh { sh_setTopComment - sh_setVariableNames } diff --git a/tcar-scripts-tuneup/Modules/Sh/sh_setVariableNames.sh b/tcar-scripts-tuneup/Modules/Sh/sh_setVariableNames.sh deleted file mode 100755 index 588f325..0000000 --- a/tcar-scripts-tuneup/Modules/Sh/sh_setVariableNames.sh +++ /dev/null @@ -1,37 +0,0 @@ -#!/bin/bash -###################################################################### -# -# sh_setVariableNames.sh -- This function standardizes presentation -# of variable's names inside shell scripts. -# -# Copyright (C) 2009-2013 The CentOS Project -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or (at -# your option) any later version. -# -# This program is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -# -###################################################################### - -function sh_setVariableNames { - - local -a COMMANDS - - # Write non-array variable names all in upper case and between - # brackets. For example: ${VARIABLE} -> ${VARIABLE} - COMMANDS[++((${#COMMANDS[*]}))]='s/\$(\w+\b|@)/${\U\1}/g' - - for COMMAND in ${COMMANDS[*]};do - sed -r -i ${COMMAND} ${FILE} - done - -}